Date: Wed, 25 Feb 2009 17:03:52 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org, Andrew Gallatin <gallatin@cs.duke.edu> Subject: Re: svn commit: r189044 - in stable/7/sys: . contrib/pf dev/ath/ath_hal dev/cxgb kern Message-ID: <20090225170115.R53478@maildrop.int.zabbadoz.net> In-Reply-To: <200902251142.38334.jhb@freebsd.org> References: <200902251504.n1PF4UjR000511@svn.freebsd.org> <49A571BE.4060107@cs.duke.edu> <200902251142.38334.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 25 Feb 2009, John Baldwin wrote:
> On Wednesday 25 February 2009 11:28:46 am Andrew Gallatin wrote:
>> Just picking a commit at random, but is there any way
>> to clean up the props on pf, ath and cxgb:
>>
>>> stable/7/sys/contrib/pf/ (props changed)
>>> stable/7/sys/dev/ath/ath_hal/ (props changed)
>>> stable/7/sys/dev/cxgb/ (props changed)
>>> stable/7/sys/kern/kern_descrip.c
>>
>> Or at the very least, have the email script ignore them?
>>
>> Having this props change garbage always in the $SUBJECT of
>> MFCs makes it very hard to distinguish from the commit
>> message what part of the tree is actually changing.
>
> In theory the mail script is just a python script in svnadmin so we can change
> it. I know several folks miss the subject lines from CVS that had all the
> filenames (so you could easily search for commit e-mails to a file by
> searching subjects in a mail client like kmail), and excluding paths that
> only have property changes at the same time would probably be good.
I think there are two points here:
1) the svn interface; I remember peter mumbling something about old we
use and new one. Maybe that was for something else.
2) the script itself seems very readable but it made me run away last
time I tried to look at this.
If you like python and have a svn test installation with the freebsd
setup it's probably fixable; we could at least sort the prop-only
changes to the end of the subject.
I think we might need to keep them for the time when people do
svn merge --record-only
as that ends to be a prop-only change as well.
--
Bjoern A. Zeeb The greatest risk is not taking one.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090225170115.R53478>