Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 May 2010 12:01:27 -0700
From:      Garrett Cooper <yanefbsd@gmail.com>
To:        d@delphij.net
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, Rob Farmer <rfarmer@predatorlabs.net>, Xin LI <delphij@freebsd.org>, src-committers@freebsd.org
Subject:   Re: svn commit: r208545 - in head/release: amd64 i386 ia64 pc98  powerpc sparc64 sun4v
Message-ID:  <AANLkTik6tiirDXup-eFcfqZzvvlCqWQnUphvWsWPO1ep@mail.gmail.com>
In-Reply-To: <4BFD6F80.8030700@delphij.net>
References:  <201005251748.o4PHmI5T093246@svn.freebsd.org> <AANLkTilcASoInnpr5OL5usR7exerst2lTq7Wi_ypD_Tw@mail.gmail.com> <AANLkTimC39JXRyAAQnXI5qjHnIhLwczCPn22r8XmnhBu@mail.gmail.com> <4BFD6F80.8030700@delphij.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 26, 2010 at 11:59 AM, Xin LI <delphij@delphij.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 2010/05/26 11:47, Garrett Cooper wrote:
>> On Wed, May 26, 2010 at 11:28 AM, Rob Farmer <rfarmer@predatorlabs.net> =
wrote:
>>> On Tue, May 25, 2010 at 10:48 AM, Xin LI <delphij@freebsd.org> wrote:
>>>> Author: delphij
>>>> Date: Tue May 25 17:48:17 2010
>>>> New Revision: 208545
>>>> URL: http://svn.freebsd.org/changeset/base/208545
>>>>
>>>> Log:
>>>> =A0libarchive now needs libcrypto and liblzma.
>>>>
>>>> Modified:
>>>> =A0head/release/amd64/boot_crunch.conf
>>>> =A0head/release/i386/boot_crunch.conf
>>>> =A0head/release/ia64/boot_crunch.conf
>>>> =A0head/release/pc98/boot_crunch.conf
>>>> =A0head/release/powerpc/boot_crunch.conf
>>>> =A0head/release/sparc64/boot_crunch.conf
>>>> =A0head/release/sun4v/boot_crunch.conf
>>>>
>>>> Modified: head/release/amd64/boot_crunch.conf
>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>>> --- head/release/amd64/boot_crunch.conf Tue May 25 17:43:23 2010 =A0 =
=A0 =A0 =A0(r208544)
>>>> +++ head/release/amd64/boot_crunch.conf Tue May 25 17:48:17 2010 =A0 =
=A0 =A0 =A0(r208545)
>>>> @@ -39,6 +39,6 @@ progs ppp
>>>> =A0progs sysinstall
>>>> =A0progs usbconfig
>>>>
>>>> -libs -ll -ledit -lutil -lmd -lcrypt -lftpio -lz -lnetgraph
>>>> +libs -ll -ledit -lutil -lmd -lcrypt -lcrypto -lftpio -lz -lnetgraph
>>>> =A0libs -ldialog -lncurses -ldisk -lcam -lsbuf -lufs -ldevinfo
>>>> -libs -lbsdxml -larchive -lbz2 -lusb -ljail
>>>> +libs -lbsdxml -larchive -lbz2 -llzma -lusb -ljail
>>>>
>>>
>>> Does the order of the libs entries matter? Because I just tried on
>>> i386 after this commit and I still get errors related to the sha1,
>>> md5, etc. functions but it worked fine with -llzma -lcrypto at the end
>>> of the last line.
>>
>> =A0 =A0 In theory it shouldn't because the linker should be smart enough
>> to evaluate the dependencies and link everything properly, but our
>> copy of binutils isn't intelligent enough to determine the appropriate
>> order from what I've seen.
>
> Bad last minute change from me, I overlooked this :-/
>
> Will a newer GNU ld solve this issue?

Juli informed me (off-list) that GNU ld _does_ in fact do this, but
only if you specify --start-group and --end-group in the linker
arguments (which she claimed required more RAM).

It might just be better to switch the linker library ordering as this
would fix the issue cleanly and quickly.

Thanks,
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTik6tiirDXup-eFcfqZzvvlCqWQnUphvWsWPO1ep>