Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 14 Oct 2013 17:54:21 +0400
From:      Sergey Kandaurov <pluknet@freebsd.org>
To:        "Alexander V. Chernikov" <melifaro@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r248070 - head/sys/net
Message-ID:  <CAE-mSO%2BdPGuAV-mFhVvXCWzfC3R-6zmcCbb=8pGuy91dsX1jTg@mail.gmail.com>
In-Reply-To: <201303082033.r28KXpKK057468@svn.freebsd.org>
References:  <201303082033.r28KXpKK057468@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 9 March 2013 00:33, Alexander V. Chernikov <melifaro@freebsd.org> wrote:
> Author: melifaro
> Date: Fri Mar  8 20:33:50 2013
> New Revision: 248070
> URL: http://svnweb.freebsd.org/changeset/base/248070
>
> Log:
>   Fix long-standing issue with interface routes being unprotected:
>   Use RTM_PINNED flag to mark route as immutable.
>   Forbid deleting immutable routes without special rtrequest1_fib() flag.
>   Adding interface address with prefix already in route table is handled
>   by atomically deleting old prefix and adding interface one.
>
>   Discussed with:       andre, eri
>   MFC after:    3 weeks
[...]

> Modified: head/sys/net/route.h
> ==============================================================================
> --- head/sys/net/route.h        Fri Mar  8 20:23:55 2013        (r248069)
> +++ head/sys/net/route.h        Fri Mar  8 20:33:50 2013        (r248070)
> @@ -176,7 +176,7 @@ struct ortentry {
>  /*                     0x20000            unused, was RTF_WASCLONED */
>  #define RTF_PROTO3     0x40000         /* protocol specific routing flag */
>  /*                     0x80000            unused */
> -#define RTF_PINNED     0x100000        /* future use */
> +#define RTF_PINNED     0x100000        /* route is immutable */
>  #define        RTF_LOCAL       0x200000        /* route represents a local address */
>  #define        RTF_BROADCAST   0x400000        /* route represents a bcast address */
>  #define        RTF_MULTICAST   0x800000        /* route represents a mcast address */

man rtentry(9) still references it as "Reserved for future use".
Probably this simple change should suffice:

Index: share/man/man9/rtentry.9
===================================================================
--- share/man/man9/rtentry.9    (revision 256125)
+++ share/man/man9/rtentry.9    (working copy)
@@ -28,7 +28,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd December 11, 2008
+.Dd October 14, 2013
 .Dt RTENTRY 9
 .Os
 .Sh NAME
@@ -154,8 +154,7 @@
 .It Dv RTF_PRCLONING
 This flag is obsolete and simply ignored by facility.
 .It Dv RTF_PINNED
-(Reserved for future use to indicate routes which are not to be
-modified by a routing protocol.)
+Indicates that this route is immutable to a routing protocol.
 .It Dv RTF_LOCAL
 Indicates that the destination of this route is an address configured
 as belonging to this system.

-- 
wbr,
pluknet



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSO%2BdPGuAV-mFhVvXCWzfC3R-6zmcCbb=8pGuy91dsX1jTg>