Date: Thu, 30 May 2019 17:27:40 +0000 (UTC) From: Navdeep Parhar <np@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r348440 - head/sys/dev/cxgbe/tom Message-ID: <201905301727.x4UHReMi093927@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: np Date: Thu May 30 17:27:40 2019 New Revision: 348440 URL: https://svnweb.freebsd.org/changeset/base/348440 Log: cxgbe/t4_tom: Do not attempt to look up entries in the TCB history if it hasn't been initialized. This fixes a bug in r346570 that could cause a panic when servicing TCP_INFO for offloaded connections. MFC after: 3 days Sponsored by: Chelsio Communications Modified: head/sys/dev/cxgbe/tom/t4_tom.c Modified: head/sys/dev/cxgbe/tom/t4_tom.c ============================================================================== --- head/sys/dev/cxgbe/tom/t4_tom.c Thu May 30 17:00:57 2019 (r348439) +++ head/sys/dev/cxgbe/tom/t4_tom.c Thu May 30 17:27:40 2019 (r348440) @@ -537,6 +537,9 @@ lookup_tcb_histent(struct adapter *sc, u_int tid, bool MPASS(tid < sc->tids.ntids); + if (td->tcb_history == NULL) + return (NULL); + if (addrem) rw_wlock(&td->tcb_history_lock); else
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905301727.x4UHReMi093927>