Date: Tue, 3 Feb 1998 08:44:30 +1100 (EST) From: "Daniel O'Callaghan" <danny@panda.hilink.com.au> To: Alex Nash <nash@Mcs.Net> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sbin@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw.c Message-ID: <Pine.BSF.3.91.980203084013.294G-100000@panda.hilink.com.au> In-Reply-To: <Pine.BSF.3.95.980202093903.17454A-100000@Jupiter.Mcs.Net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2 Feb 1998, Alex Nash wrote: > > Revision Changes Path > > 1.23.2.10 +7 -1 src/sbin/ipfw/ipfw.8 > > 1.34.2.11 +167 -93 src/sbin/ipfw/ipfw.c > ^^^^^^^^ > IIRC, this is considerably more than what was submitted :) Also, do we > really want to put such large changes into the 2.2 branch without any > testing in -current? The changes basically moved the getopt into a function and used a struct of option flags instead of discrete ints. The line count makes it look a lot bigger than it is. I also tidied some spacing and comments. I would have put it in -current last night, but the %lu -> %qu changes meant that hand merging is needed, and I was tired - better to do this with a fresh mind. Danny
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.91.980203084013.294G-100000>