Date: Thu, 29 Jan 2009 20:23:53 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Edward Tomasz Napierala <trasz@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r187894 - head/sys/ufs/ffs Message-ID: <20090129182353.GB2471@deviant.kiev.zoral.com.ua> In-Reply-To: <20090129181523.GA2471@deviant.kiev.zoral.com.ua> References: <200901291647.n0TGlFHZ058776@svn.freebsd.org> <200901291209.14313.jhb@freebsd.org> <20090129181523.GA2471@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--jho1yZJdad60DJr+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 29, 2009 at 08:15:23PM +0200, Kostik Belousov wrote: > On Thu, Jan 29, 2009 at 12:09:13PM -0500, John Baldwin wrote: > > On Thursday 29 January 2009 11:47:15 am Edward Tomasz Napierala wrote: > > > Author: trasz > > > Date: Thu Jan 29 16:47:15 2009 > > > New Revision: 187894 > > > URL: http://svn.freebsd.org/changeset/base/187894 > > >=20 > > > Log: > > > Make sure the cdev doesn't go away while the filesystem is still mo= unted. > > > Otherwise dev2udev() could return garbage. > > > =20 > > > Reviewed by: kib > > > Approved by: rwatson (mentor) > > > Sponsored by: FreeBSD Foundation > >=20 > > Is this applicable to all filesystems? I'm curious why the VREF() on t= he=20 > > vnode associated with the cdev entry (um_devvp) is not sufficient to pr= event=20 > > this? I would have thought that the vnode would have held a reference = on the=20 > > cdev. >=20 > The point of this commit is that devvp vnode may be reclaimed. And, in fact, it may be clearer to get the ref while devvp is still locked. I do not think that this is important because mount would fail immediately later when it tries to read from device, but still. --jho1yZJdad60DJr+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmB9DgACgkQC3+MBN1Mb4hO0QCfVXn+xfLy193uUXlkorE3GDZ6 hLMAoPFMaoWo7Ckcs/vwnSYpnbiWpVN8 =Vmso -----END PGP SIGNATURE----- --jho1yZJdad60DJr+--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090129182353.GB2471>