Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 30 Dec 2017 14:42:28 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        Pedro Giffuni <pfg@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r327381 - in head/sys: conf dev/ep i386/isa modules modules/elink modules/ep
Message-ID:  <CANCZdfpQRxxeaT3FMCbFffF_kWSpY=cVJ6uSLe6RAU=ivyJg6g@mail.gmail.com>
In-Reply-To: <20171230211428.GU1684@kib.kiev.ua>
References:  <201712301142.vBUBgnXl095227@repo.freebsd.org> <fe8e0904-75db-fa9f-424f-9634735d219f@FreeBSD.org> <20171230211428.GU1684@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 30, 2017 at 2:14 PM, Konstantin Belousov <kostikbel@gmail.com>
wrote:

> On Sat, Dec 30, 2017 at 04:02:39PM -0500, Pedro Giffuni wrote:
> > Hi;
> >
> > On 30/12/2017 06:42, Konstantin Belousov wrote:
> > > Author: kib
> > > Date: Sat Dec 30 11:42:49 2017
> > > New Revision: 327381
> > > URL: https://svnweb.freebsd.org/changeset/base/327381
> > >
> > > Log:
> > >    Move i386/isa/elink.[hc] to dev/ep.
> > >
> > >    The ep(4) driver is the only consumer of the two functions from
> > >    elink.c.  I removed the standalone module as well, and most likely,
> > >    the module metadata is not needed anywhere, but this is for later
> > >    cleanup.
> > >
> > >    Discussed with:  imp, jhb
> > >    Sponsored by:    The FreeBSD Foundation
> > For the record, I find this change very cool.
> >
> > It makes the code more modular and the license for those two files also
> > matches the license in the ep driver.
>
> The idea of this change and r327380 is to clean up i386/isa.  There are
> three more files to go
>

Originally, the ie driver and the ep driver shared the elink code since
there were two different drivers, but the same pre-PNP discovery method for
these cards. It makes sense to do what was just done now that ie is gone.

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpQRxxeaT3FMCbFffF_kWSpY=cVJ6uSLe6RAU=ivyJg6g>