Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 12 Apr 2007 13:58:02 GMT
From:      "Christian S.J. Peron" <csjp@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 117965 for review
Message-ID:  <200704121358.l3CDw2AT013869@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=117965

Change 117965 by csjp@csjp_push on 2007/04/12 13:57:46

	Add some bzero()s to ensure that we are proerly clearing any old data.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/security/audit/audit_syscalls.c#31 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/security/audit/audit_syscalls.c#31 (text+ko) ====

@@ -534,6 +534,7 @@
 		PROC_UNLOCK(td->td_proc);
 		return (E2BIG);
 	}
+	bzero(&ai, sizeof(ai));
 	ai.ai_auid = td->td_proc->p_au->ai_auid;
 	ai.ai_mask = td->td_proc->p_au->ai_mask;
 	ai.ai_asid = td->td_proc->p_au->ai_asid;
@@ -573,6 +574,7 @@
 	 * XXXRW: Test privilege while holding the proc lock?
 	*/
 	PROC_LOCK(td->td_proc);
+	bzero(td->td_proc->p_au, sizeof(struct auditinfo_addr));
 	td->td_proc->p_au->ai_auid = ai.ai_auid;
 	td->td_proc->p_au->ai_mask = ai.ai_mask;
 	td->td_proc->p_au->ai_asid = ai.ai_asid;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704121358.l3CDw2AT013869>