Date: Tue, 23 Aug 2011 07:44:16 +0400 From: Andrey Chernov <ache@FreeBSD.ORG> To: Gabor Kovesdan <gabor@FreeBSD.ORG> Cc: src-committers@FreeBSD.ORG, svn-src-user@FreeBSD.ORG Subject: Re: svn commit: r225093 - in user/gabor/tre-integration: contrib/tre/lib include Message-ID: <20110823034416.GA7597@vniz.net> In-Reply-To: <201108222319.p7MNJKZ4072487@svn.freebsd.org> References: <201108222319.p7MNJKZ4072487@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 22, 2011 at 11:19:20PM +0000, Gabor Kovesdan wrote:
> Modified: user/gabor/tre-integration/include/regex.h
> ==============================================================================
> --- user/gabor/tre-integration/include/regex.h Mon Aug 22 23:15:15 2011 (r225092)
> +++ user/gabor/tre-integration/include/regex.h Mon Aug 22 23:19:20 2011 (r225093)
> @@ -110,6 +110,7 @@ typedef enum {
> #define REG_PEND (REG_UNGREEDY << 1)
> #define REG_GNU (REG_PEND << 1)
> #define REG_WORD (REG_GNU << 1)
> +#define _REG_HEUR (REG_WORD << 1)
Not a good place. Next extension flag from TRE author or POSIX will break
binary compatibility badly. It will be better to put it to the end of a
word instead or don't use this field at all (converting to another
internal function argument etc.), which is much safer.
--
http://ache.vniz.net/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110823034416.GA7597>