Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Jan 2006 14:28:22 -0500
From:      Tom Rhodes <trhodes@FreeBSD.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/nfsserver nfs_serv.c
Message-ID:  <20060123142822.1be78fcb.trhodes@FreeBSD.org>
In-Reply-To: <200601231356.18292.jhb@freebsd.org>
References:  <200601211210.k0LCAXYl069896@repoman.freebsd.org> <200601231356.18292.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Jan 2006 13:56:16 -0500
John Baldwin <jhb@FreeBSD.org> wrote:

> On Saturday 21 January 2006 07:10, Tom Rhodes wrote:
> > trhodes     2006-01-21 12:10:33 UTC
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/nfsserver        nfs_serv.c
> >   Log:
> >   Remove some dead code.
> >
> >   Found with:     Coverity Prevent(tm)
> 
> Are you going to revert this change given the replies?

Oh, I didn't interpret the comments as "this is wrong please
back it out."  I just seen replies, both public and private,
complaining about the indentation.  They went like:

stefanf: "Are you sure this is correct?"
  rwatson: "code is a mess in NFS"

ru: quoting the code "bad indentation"
njl quoting the code "bad indentation"

rees (NFSv4 guy): "looks fine to me"

If you, or anyone else for that matter actually wants it
reverted, I'll do that.  I'm not in the mood to argue
with people today, or ever.  :)

-- 
Tom Rhodes



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060123142822.1be78fcb.trhodes>