Date: Thu, 29 Sep 2011 16:34:52 +0800 From: Adrian Chadd <adrian@freebsd.org> To: Alexander Motin <mav@freebsd.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r225860 - user/adrian/if_ath_tx/sys/mips/mips Message-ID: <CAJ-VmokRB-w4fLEp2xnS=XN2N3EUc3qgjBRiKTQWvPrtoGtyLA@mail.gmail.com> In-Reply-To: <4E84222F.7050101@FreeBSD.org> References: <201109290310.p8T3AgZO001901@svn.freebsd.org> <4E84222F.7050101@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29 September 2011 15:45, Alexander Motin <mav@freebsd.org> wrote: > I think that's not good to call intr_disable() before cpu_idleclock(). > cpu_idleclock() uses spin mutex to serialize timer hardware accesses, > which disables interrupts. When it enable them back, it will revert > effect of your intr_disable() also. .. wait. So spinlocks don't save/restore the interrupt state? They just enable/disable it? Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokRB-w4fLEp2xnS=XN2N3EUc3qgjBRiKTQWvPrtoGtyLA>