Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jul 2018 09:29:00 +0000 (UTC)
From:      Tobias Kortkamp <tobik@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r475873 - head/games/xminehunter
Message-ID:  <201807300929.w6U9T0M1024105@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tobik
Date: Mon Jul 30 09:29:00 2018
New Revision: 475873
URL: https://svnweb.freebsd.org/changeset/ports/475873

Log:
  games/xminehunter: Fix build with Clang 6
  
  ./bitmaps/bomb:5:28: error: constant expression evaluates to 144 which cannot be narrowed to type 'char' [-Wc++11-narrowing]
     0x00, 0x00, 0x00, 0x00, 0x90, 0x00, 0x00, 0x00, 0x40, 0x02, 0x00, 0x00,
                             ^~~~
  
  http://beefy12.nyi.freebsd.org/data/head-amd64-default/p475478_s336801/logs/errors/xminehunter-0.4_4.log
  
  - Actually install the binary as executable (broken 5 years ago in r337083)

Modified:
  head/games/xminehunter/Makefile

Modified: head/games/xminehunter/Makefile
==============================================================================
--- head/games/xminehunter/Makefile	Mon Jul 30 09:16:04 2018	(r475872)
+++ head/games/xminehunter/Makefile	Mon Jul 30 09:29:00 2018	(r475873)
@@ -3,7 +3,7 @@
 
 PORTNAME=	xminehunter
 PORTVERSION=	0.4
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	games
 MASTER_SITES=	XCONTRIB/games
 
@@ -17,10 +17,12 @@ LICENSE_PERMS=	dist-mirror pkg-mirror auto-accept
 
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
-USES=		motif
+USES=		compiler motif
 USE_XORG=	xpm
 ALL_TARGET=	${PORTNAME}
 
+CXXFLAGS+=	${CXXFLAGS_${CHOSEN_COMPILER_TYPE}}
+CXXFLAGS_clang=	-Wno-c++11-narrowing
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 
@@ -43,13 +45,12 @@ post-patch:
 		 s|$${CFLAGS}|$${CXXFLAGS}| ; \
 		 s| \($${INSTALL_SCORE_PATH}\)| $${DESTDIR}\1| ; \
 		 s|chmod 333|chmod 633| ; \
-		 s|cp |$${BSD_INSTALL_DATA} | ; \
+		 s|cp |$${BSD_INSTALL_PROGRAM} | ; \
 		 s| \($${INSTALL_BIN_PATH}\)| $${DESTDIR}\1|' \
 		${WRKSRC}/${MAKEFILE}
 
 post-install:
 	(cd ${WRKSRC}/bitmaps && ${INSTALL_DATA} normal.xpm \
 		${STAGEDIR}${PREFIX}/share/pixmaps/${PORTNAME}.xpm)
-	${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${PORTNAME}
 
 .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807300929.w6U9T0M1024105>