Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Jul 2013 17:08:26 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Gabor Kovesdan <gabor@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r323538 - in head/x11-fonts: . andika andika/files
Message-ID:  <20130724170826.GA10662@FreeBSD.org>
In-Reply-To: <201307231610.r6NGAAwC070825@svn.freebsd.org>
References:  <201307231610.r6NGAAwC070825@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 23, 2013 at 04:10:10PM +0000, Gabor Kovesdan wrote:
> New Revision: 323538
> URL: http://svnweb.freebsd.org/changeset/ports/323538
> 
> @@ -0,0 +1,50 @@
> +# $FreeBSD$
> +
> +PORTNAME=	Andika

Any reason for uppercase-starting PORTNAME (and thus PKGNAME)?

> +do-configure:
> +	${DO_NADA}

If port does not use any of two *_CONFIGURE knobs, this probably is not
needed; and even if it is, it should be spelled as @${DO_NADA}.

> +do-install:
> +	${ECHO_MSG}
> +	${CAT} ${PKGMESSAGE}
> +	${ECHO_MSG}

We usually display pkg-message as the last step (after all other functional
commands).

> +	${MKDIR} ${FONTROOTDIR}/${FONTDIR}
> +	${INSTALL_DATA} ${WRKSRC}/*.ttf ${FONTROOTDIR}/${FONTDIR}
> +.if ${PORT_OPTIONS:MDOCS}
> +	${MKDIR} ${DOCSDIR}
> +	${INSTALL_DATA} ${DOCSLIST:S,^,${WRKSRC}/,} ${DOCSDIR}
> +.endif

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130724170826.GA10662>