Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 18 Jun 2019 13:04:14 +0200
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        =?utf-8?Q?T=C4=B3l?= Coosemans <tijl@FreeBSD.org>
Cc:        Mathieu Arnold <mat@FreeBSD.org>, bapt@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r503385 - head/Mk/Scripts
Message-ID:  <20190618110414.ngqcgv4gydfkmk6z@ogg.in.absolight.net>
In-Reply-To: <20190615170158.489616a4@kalimero.tijl.coosemans.org>
References:  <201906031257.x53Cvi9P092541@repo.freebsd.org> <20190615170158.489616a4@kalimero.tijl.coosemans.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--qzmheo4mipeqazyc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 15, 2019 at 05:01:58PM +0200, T=C4=B3l Coosemans wrote:
> On Mon, 3 Jun 2019 12:57:44 +0000 (UTC) Mathieu Arnold <mat@FreeBSD.org>
> wrote:
> > Author: mat
> > Date: Mon Jun  3 12:57:44 2019
> > New Revision: 503385
> > URL: https://svnweb.freebsd.org/changeset/ports/503385
> >=20
> > Log:
> >   Use UCL for pkg-message
> >  =20
> >   Remain backward compatible but use ucl for the pkg-messages, which al=
lows to:
> >   - append messages one after the other
> >   - only print message on delete, install, upgrade from a version to an=
other
> >  =20
> >   If pkg-message starts with a [ we consider it should be a valid ucl f=
ile
> >  =20
> >   The format is the following:
> >   [
> >   { message: "Always print" },
> >   { message: "package being removed", type: remove },
> >   { message: "package being installed", type: install },
> >   { message: "package is being upgraded", type: upgrade },
> >   { message: "Upgrading from lower than 1.0", maximum_version: "1.0", t=
ype: upgrade },
> >   { message: "Upgrading from higher than 1.0", minimum_version: "1.0", =
type: upgrade  },
> >   { message: "Upgrading from >1.0 < 3.0", maximum_version: "3.0", minim=
um_version: "1.0",
> >   ]
> >  =20
> >   Because it is ucl one can use some sugar like:
> >   [
> >   { message =3D <<EOD
> >   formatted
> >   message 'with fancy things'
> >   EOD
> >   },
> >   }
>=20
> Can this be extended to include these fields:
> opsys: <operating system this message applies to>
> osversion: <list of os version ranges this message applies to>
> arch: <list of architectures this message applies to>
> options: <list of options that need to be on or off>

I am not sure adding more fields is a good idea.
It should remain simple, otherwise there is a risk of the pkg-message
syntax getting bloated, and it is bound to be misused, especially as the
use case would be very rare.
It would probably be better to add files to _PKGMESSAGES when the case
you want to handle presents itself.

--=20
Mathieu Arnold

--qzmheo4mipeqazyc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAl0IxS1fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB
QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD
zkhJ3xAAmvvcZnoEG1nTSBavb7oN9f5sDB324W6TZhH0dO+GQMYA0LJ+KzERAKES
s5TzUE5PK4BhwWhgiJOsQsY3+qUe1+RjsFdDf6RG4IoufNFvD5NNmDR5Jq2s0JF+
Gxmi0VFNtvdSAgb5WpYHxhn4qfflD5sxsGf60rJs4wIq1AJpI+oXmU9ILqExYmtK
q2kkQM2DXP7zLGge+25UHyDak9GTGoYsEzakPjgJVjquG8PgmJcpCTNx0bGcrfW/
yvIMAjO7b3JGHCso7I/Lj69kTiQKzsUAmnQPFmuPMvoXI07Nfkr006kC5NVhQLMr
wCzgyNxuws37paIPTJj8v3TMv52K2TdkMu5lMylW8Yc5ji5CJL1eIi3yY053v7f7
AcAQlSNQ1mUXk4qTLrgv6x7ie1NfULsTFlJoibzCmsoqnfj0KBTgkzbEds4R9u7B
bmUhwWaaBmYd/dbZ4wXZbw8bJXvsFM6HNwt+uW9sOpaL/CpivJoksUBVn0IROQpq
2BfyoBntgOxj3QW9IxnmRMkO4Er5a1ZKtYV0a0lIPQew4EQDaBz480DPBjmkwwMr
k4VXAP0ERJV37NMcepsqa2qZDB+pD1d+/FJGZmD1enOZtjAUiyLXEd01zQPZNR6A
prtvmXbn8c5eoBoXKiw/FnMcKLVDKIdKtCQz+awF8wgY9jNw2Do=
=APjW
-----END PGP SIGNATURE-----

--qzmheo4mipeqazyc--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190618110414.ngqcgv4gydfkmk6z>