Date: Sat, 14 Mar 2020 10:40:08 -0700 From: Conrad Meyer <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r358988 - head/usr.bin/gzip Message-ID: <CAG6CVpUjY7dGQfcgRwXmkvdY3JLndMzxwm_ijn=qvef0yFE5Lw@mail.gmail.com> In-Reply-To: <202003140557.02E5vMBA097086@repo.freebsd.org> References: <202003140557.02E5vMBA097086@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
For additional context, this quiesces (false positive) Coverity CID 1383554. On Fri, Mar 13, 2020 at 10:57 PM Xin LI <delphij@freebsd.org> wrote: > > Author: delphij > Date: Sat Mar 14 05:57:22 2020 > New Revision: 358988 > URL: https://svnweb.freebsd.org/changeset/base/358988 > > Log: > Remove unneeded checks for prelen. > > In order to determine the type of a compressed file, we have to read > in the first four bytes which may also be important for decompression > purposes, to do that we would pass the buffer that we have already > read in, along with the size of it. > > Rename header1 to fourbytes to make that explicit, and remove all > checks for prelen.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUjY7dGQfcgRwXmkvdY3JLndMzxwm_ijn=qvef0yFE5Lw>