Date: Fri, 19 Aug 2016 09:52:25 +0900 From: YongHyeon PYUN <pyunyh@gmail.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: Pyun YongHyeon <yongari@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304326 - head/sys/dev/usb/net Message-ID: <20160819005225.GA1234@michelle.fasterthan.co.kr> In-Reply-To: <F05575AA-18B3-4ABD-A346-59C210D76A8A@lists.zabbadoz.net> References: <201608180507.u7I572ZI096519@repo.freebsd.org> <F05575AA-18B3-4ABD-A346-59C210D76A8A@lists.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 18, 2016 at 04:44:29PM +0000, Bjoern A. Zeeb wrote: > On 18 Aug 2016, at 5:07, Pyun YongHyeon wrote: > > >Author: yongari > >Date: Thu Aug 18 05:07:02 2016 > >New Revision: 304326 > >URL: https://svnweb.freebsd.org/changeset/base/304326 > > [...] > >+struct axge_frame_txhdr { > >+#if BYTE_ORDER == LITTLE_ENDIAN > >+ uint32_t len; > >+#define AXGE_TXLEN_MASK 0x0001FFFF > >+#define AXGE_VLAN_INSERT 0x20000000 > >+#define AXGE_CSUM_DISABLE 0x80000000 > >+ uint32_t mss; > >+#define AXGE_MSS_MASK 0x00003FFF > >+#define AXGE_PADDING 0x80008000 > >+#define AXGE_VLAN_TAG_MASK 0xFFFF0000 > >+#else > >+ uint32_t mss; > >+ uint32_t len; > >+#endif > >+} __packed; > >+ > >+#define AXGE_TXBYTES(x) ((x) & AXGE_TXLEN_MASK) > > > AXGE_TXLEN_MASK is only defined for LITTLE_ENDIAN and thus breaks builds > on others. > > AXGE_CSUM_DISABLE as well .. > Oops, fixed in r304439. Thanks.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160819005225.GA1234>