Date: Wed, 27 Feb 2008 22:35:28 GMT From: Steve Wise <swise@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 136373 for review Message-ID: <200802272235.m1RMZSTa033372@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=136373 Change 136373 by swise@swise:vic10:iwarp on 2008/02/27 22:35:25 Fixed recursive lock bugs. Affected files ... .. //depot/projects/iwarp/sys/contrib/rdma/krping/krping.c#10 edit .. //depot/projects/iwarp/sys/contrib/rdma/rdma_iwcm.c#9 edit Differences ... ==== //depot/projects/iwarp/sys/contrib/rdma/krping/krping.c#10 (text+ko) ==== @@ -308,12 +308,10 @@ cb->remote_rkey, (unsigned long long)cb->remote_addr, cb->remote_len); - mtx_lock_spin(&cb->lock); if (cb->state <= CONNECTED || cb->state == RDMA_WRITE_COMPLETE) cb->state = RDMA_READ_ADV; else cb->state = RDMA_WRITE_ADV; - mtx_unlock_spin(&cb->lock); return 0; } @@ -326,12 +324,10 @@ return -1; } - mtx_lock_spin(&cb->lock); if (cb->state == RDMA_READ_ADV) cb->state = RDMA_WRITE_ADV; else cb->state = RDMA_WRITE_COMPLETE; - mtx_unlock_spin(&cb->lock); return 0; } ==== //depot/projects/iwarp/sys/contrib/rdma/rdma_iwcm.c#9 (text+ko) ==== @@ -957,9 +957,7 @@ } } - mtx_lock_spin(&cm_id_priv->lock); atomic_inc(&cm_id_priv->refcount); - mtx_unlock_spin(&cm_id_priv->lock); if (TAILQ_EMPTY(&cm_id_priv->work_list)) { TAILQ_INSERT_TAIL(&cm_id_priv->work_list, work, list); taskqueue_enqueue(iwcm_wq, &work->task);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802272235.m1RMZSTa033372>