Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Apr 2020 15:05:11 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r360075 - head/sys/dev/usb/controller
Message-ID:  <202004181505.03IF5BFG010542@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Sat Apr 18 15:05:10 2020
New Revision: 360075
URL: https://svnweb.freebsd.org/changeset/base/360075

Log:
  Set the maximum exit latency to 0 for XHCI USB 3.0 devices, because we
  don't implement link power management, LPM.
  
  This fixes error code XHCI_TRB_ERROR_BANDWIDTH for isochronous USB 3.0
  transactions.
  
  Submitted by:	Horse Ma <Shichun.Ma@dell.com>
  MFC after:	1 week
  Sponsored by:	Mellanox Technologies

Modified:
  head/sys/dev/usb/controller/xhci.c

Modified: head/sys/dev/usb/controller/xhci.c
==============================================================================
--- head/sys/dev/usb/controller/xhci.c	Sat Apr 18 13:29:54 2020	(r360074)
+++ head/sys/dev/usb/controller/xhci.c	Sat Apr 18 15:05:10 2020	(r360075)
@@ -2665,23 +2665,6 @@ xhci_configure_device(struct usb_device *udev)
 		    sc->sc_hw.devs[index].nports);
 	}
 
-	switch (udev->speed) {
-	case USB_SPEED_SUPER:
-		switch (sc->sc_hw.devs[index].state) {
-		case XHCI_ST_ADDRESSED:
-		case XHCI_ST_CONFIGURED:
-			/* enable power save */
-			temp |= XHCI_SCTX_1_MAX_EL_SET(sc->sc_exit_lat_max);
-			break;
-		default:
-			/* disable power save */
-			break;
-		}
-		break;
-	default:
-		break;
-	}
-
 	xhci_ctx_set_le32(sc, &pinp->ctx_slot.dwSctx1, temp);
 
 	temp = XHCI_SCTX_2_IRQ_TARGET_SET(0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202004181505.03IF5BFG010542>