Date: Fri, 27 Apr 2001 18:06:09 +0200 From: Maxime Henrion <mux@qualys.com> To: audit@FreeBSD.org Cc: Chris Faulhaber <jedgar@fxp.org> Subject: Re: [PATCH] wall.c changes from OpenBSD Message-ID: <20010427180609.A1371@nebula.cybercable.fr> In-Reply-To: <20010427092403.A32859@peitho.fxp.org>; from jedgar@fxp.org on Fri, Apr 27, 2001 at 09:24:03AM -0400 References: <20010427150436.A1170@nebula.cybercable.fr> <20010427092403.A32859@peitho.fxp.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Chris Faulhaber wrote: > On Fri, Apr 27, 2001 at 03:04:36PM +0200, Maxime Henrion wrote: > > Hello, > > > > This patch makes wall open the file with the egid, as taken from the > > OpenBSD mbox of Kris. I changed several err() to errx() and added some > > dots to end of sentences to match OpenBSD and reduce the diffs. > I disagree with the err() -> errx() changes. Since err() prints the > error message from strerror() whereas errx() does not, this patch > removes this reporting ensuring the user will not be informed of the > actual error. Agreed. Throw these changed then :-) > The other change(s) look ok, though. Thanks. Maxime -- Don't be fooled by cheap finnish imitations ; BSD is the One True Code Key fingerprint = F9B6 1D5A 4963 331C 88FC CA6A AB50 1EF2 8CBE 99D6 Public Key : http://www.epita.fr/~henrio_m/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010427180609.A1371>