Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Jan 2007 16:02:41 GMT
From:      Todd Miller <millert@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 113343 for review
Message-ID:  <200701221602.l0MG2fa8025509@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=113343

Change 113343 by millert@millert_macbook on 2007/01/22 16:01:43

	Ports returned by ipc_port_alloc_kernel() are not locked.

Affected files ...

.. //depot/projects/trustedbsd/sedarwin8/darwin/xnu/osfmk/ipc/ipc_labelh.c#10 edit

Differences ...

==== //depot/projects/trustedbsd/sedarwin8/darwin/xnu/osfmk/ipc/ipc_labelh.c#10 (text+ko) ====

@@ -122,9 +122,6 @@
 	lh->lh_port = ipc_port_alloc_kernel();
 	lh->lh_type = LABELH_TYPE_KERN;
 	lh->lh_references = 1;
-	ip_unlock(lh->lh_port);
-
-	/* Must call ipc_kobject_set() with port unlocked. */
 	ipc_kobject_set(lh->lh_port, (ipc_kobject_t)lh, IKOT_LABELH);
 
 	return (lh);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701221602.l0MG2fa8025509>