Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Jul 2002 16:46:15 -0700
From:      Peter Wemm <peter@wemm.org>
To:        Matthew Dillon <dillon@apollo.backplane.com>
Cc:        Dag-Erling Smorgrav <des@ofug.org>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/bin/chmod chmod.c 
Message-ID:  <20020710234615.61E5E3808@overcee.wemm.org>
In-Reply-To: <200207102316.g6ANGOGx076244@apollo.backplane.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon wrote:

>     I suppose the minimal fix is to remove __printf0like from err(),
>     errx(), and warn() in /usr/src/include/err.h.  So that is what I will
>     do if this problem isn't fixed in the tree by 9:00 p.m. PDT tonight.

No, the correct minimal fix is to stub out the attributes, that's why
we have fine granularity on them!  eg:

--- cdefs.h     2002/07/08 16:43:35     1.56
+++ cdefs.h     2002/07/10 23:18:10
@@ -174,9 +174,9 @@
            __attribute__((__format__ (__scanf__, fmtarg, firstvararg)))
 #endif
 
 /* Compiler-dependent macros that rely on FreeBSD-specific extensions. */
-#if __FreeBSD_cc_version >= 300001
+#if __FreeBSD_cc_version >= 300001 && !defined(__sparc64__)
 #define        __printf0like(fmtarg, firstvararg) \
            __attribute__((__format__ (__printf0__, fmtarg, firstvararg)))
 #else
 #define        __printf0like(fmtarg, firstvararg)

The sparc64 thing just was an example.  It may need this instead:
#if __FreeBSD_cc_version >= 300001 &&  __FreeBSD_cc_version < 500003

There, problem solved.

Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020710234615.61E5E3808>