Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 18 Oct 2013 18:31:53 +0100
From:      Jase Thew <jase@FreeBSD.org>
To:        Hiroki Sato <hrs@FreeBSD.org>, src-committers@freebsd.org,  svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r256498 - head/etc/rc.d
Message-ID:  <52617089.6090708@FreeBSD.org>
In-Reply-To: <201310150454.r9F4snOM001275@svn.freebsd.org>
References:  <201310150454.r9F4snOM001275@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Lnicen5WxNkC0evgGBmsNRL7FmJX34Or0
Content-Type: multipart/mixed;
 boundary="------------080102050103020609060206"

This is a multi-part message in MIME format.
--------------080102050103020609060206
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 15/10/2013 05:54, Hiroki Sato wrote:
> Author: hrs
> Date: Tue Oct 15 04:54:49 2013
> New Revision: 256498
> URL: http://svnweb.freebsd.org/changeset/base/256498
>=20
> Log:
>   - Fix "ifname|addr" syntax support in jail_{jname}_ip.
>   - Create /var/run/jail_{jname}.id because ezjail-admin depends on it.=

>=20
> Modified:
>   head/etc/rc.d/jail
>=20

Hi Hiroki,

This unfortunately breaks ezjail when the address list doesn't use iface
prefix syntax.

Given this configuration :

export jail_poudriere_ip=3D"192.168.1.184,127.0.1.4,::1"

results in the following being generated :

ip4.addr +=3D "|192.168.1.184/32";
ip4.addr +=3D "|127.0.1.4/32";
ip6.addr +=3D "|::1/64";

The attach patch corrects the issue by suffixing the iface value with
"|" only when it has a value.

Kind regards,

Jase.
--=20
Jase Thew
jase@FreeBSD.org
FreeBSD Ports Committer


--------------080102050103020609060206
Content-Type: text/plain; charset=windows-1252;
 name="jail_iface_prefix_20131018.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="jail_iface_prefix_20131018.patch"

LS0tIC9ldGMvcmMuZC9qYWlsLm9yaWcJMjAxMy0xMC0xOCAxNzo0Nzo1OC41MjM4NjkwMzAg
KzAxMDAKKysrIC9ldGMvcmMuZC9qYWlsCTIwMTMtMTAtMTggMTg6MTg6MzYuODU5MjIwODAw
ICswMTAwCkBAIC0zNjcsMTAgKzM2NywxMCBAQAogCQkjIEFwcGVuZCBhZGRyZXNzIHRvIGxp
c3Qgb2YgYWRkcmVzc2VzIGZvciB0aGUgamFpbCBjb21tYW5kLgogCQljYXNlICRfdHlwZSBp
bgogCQlpbmV0KQotCQkJZWNobyAiCWlwNC5hZGRyICs9IFwiJHtfaWZhY2V9fCR7X2FkZHJ9
JHtfbWFza31cIjsiCisJCQllY2hvICIJaXA0LmFkZHIgKz0gXCIke19pZmFjZTorJHtfaWZh
Y2V9fH0ke19hZGRyfSR7X21hc2t9XCI7IgogCQk7OwogCQlpbmV0NikKLQkJCWVjaG8gIglp
cDYuYWRkciArPSBcIiR7X2lmYWNlfXwke19hZGRyfSR7X21hc2t9XCI7IgorCQkJZWNobyAi
CWlwNi5hZGRyICs9IFwiJHtfaWZhY2U6KyR7X2lmYWNlfXx9JHtfYWRkcn0ke19tYXNrfVwi
OyIKIAkJCW5lZWRfZGFkX3dhaXQ9MQogCQk7OwogCQllc2FjCg==
--------------080102050103020609060206--

--Lnicen5WxNkC0evgGBmsNRL7FmJX34Or0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQJ8BAEBCgBmBQJSYXCTXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRGNzY3ODIxQkE1MTQ4MjNFQ0RGNUM3QkRE
NEU2NUM4QkZGMUMzODI5AAoJENTmXIv/HDgpoBMP/i7bR8EaeJF4/frf9AayF5CL
Wi3aDNRcN4kDhGikfD7fdSFHRyQlpSXkydOFYHJZG4bXPhdFjHUKoZRSaMyUEdsj
vQ0KsiLrjnBYkX6czxHf43PObTM6snZyESU4bplBXSO2HRhOVo9IlG81FEmBdesz
Qahf8gvOsmN9b4r/6/stBjaL8uTAQo+A4XydQslUNX3q1fOFn7nDFwg+xsDlNM5Y
SMGZ5cLnDb2L5fLtp7tuNqVIiPm4MuxCo/GYow7x31h/F1998Czny7xvydVtzLzM
IgDXCO75b9JHBa/n5/BN33eVr8w/zxxUu3c8Dozs4tVM6mfPMbHZI1Rj+y6Mkkw0
QgNkEVSAKg+dyhX7zssYhuUwsboa8zB4pd2xuALDRvNi18/aoKZttaj2jpn3Bamo
sOum0Y652kmc+D8/SM30ttAUDk85YodNzz4k1OJxJe2ZcZaz8FQKSpPb4G8TMnz6
YjrhPz6Waig5/fH8jfDSH1UIuP1Ce4dAr3yrnWdo8e++sbF4Y/uKtiDyfHTQIf3M
hwf8wCsJBinXkGLwi7znicYOyu2w7COdIyvgGpNFR8iyRcyUtneEV0firYLiMefx
29zO/cZ7tFQItea2j5ePv9PoFS3XrfWDRHJXNwF3ofindT10LLKUNaEPoI0q96+w
rBQVMigRZWv2AnP24cfG
=fZJZ
-----END PGP SIGNATURE-----

--Lnicen5WxNkC0evgGBmsNRL7FmJX34Or0--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52617089.6090708>