Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Dec 2008 14:03:04 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r185987 - head/sys/kern
Message-ID:  <200812121403.mBCE34qv099394@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Fri Dec 12 14:03:04 2008
New Revision: 185987
URL: http://svn.freebsd.org/changeset/base/185987

Log:
  Uio_yield() already does DROP_GIANT/PICKUP_GIANT, no need to repeat this
  around the call.
  
  Noted by:  bde

Modified:
  head/sys/kern/kern_sysctl.c

Modified: head/sys/kern/kern_sysctl.c
==============================================================================
--- head/sys/kern/kern_sysctl.c	Fri Dec 12 13:21:31 2008	(r185986)
+++ head/sys/kern/kern_sysctl.c	Fri Dec 12 14:03:04 2008	(r185987)
@@ -1423,9 +1423,7 @@ userland_sysctl(struct thread *td, int *
 		error = sysctl_root(0, name, namelen, &req);
 		if (error != EAGAIN)
 			break;
-		DROP_GIANT();
 		uio_yield();
-		PICKUP_GIANT();
 	}
 
 	if (req.lock == REQ_WIRED && req.validlen > 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812121403.mBCE34qv099394>