Date: Thu, 11 Mar 2021 09:39:04 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org>, Mateusz Guzik <mjguzik@gmail.com>, Kyle Evans <kevans@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1ae20f7c70ea - main - kern: malloc: fix panic on M_WAITOK during THREAD_NO_SLEEPING() Message-ID: <9132135e-8653-4df8-984e-c00806e4e533@FreeBSD.org> In-Reply-To: <8e37c710-bd9d-6fe0-0263-4efeabfd9beb@FreeBSD.org> References: <202103091117.129BHOZa042851@gitrepo.freebsd.org> <CAGudoHFbEt1%2BmSDx04x1-YrxwrxHMdfoRj69EV183ngZ4TkxkA@mail.gmail.com> <8e37c710-bd9d-6fe0-0263-4efeabfd9beb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aVuFBlAJPYlT86BMcrZFhw1NvKwD0NTlj Content-Type: multipart/mixed; boundary="o29koHnVcEqidntWU1GWZqJO9ROUgfbX6"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org>, Mateusz Guzik <mjguzik@gmail.com>, Kyle Evans <kevans@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-ID: <9132135e-8653-4df8-984e-c00806e4e533@FreeBSD.org> Subject: Re: git: 1ae20f7c70ea - main - kern: malloc: fix panic on M_WAITOK during THREAD_NO_SLEEPING() References: <202103091117.129BHOZa042851@gitrepo.freebsd.org> <CAGudoHFbEt1+mSDx04x1-YrxwrxHMdfoRj69EV183ngZ4TkxkA@mail.gmail.com> <8e37c710-bd9d-6fe0-0263-4efeabfd9beb@FreeBSD.org> In-Reply-To: <8e37c710-bd9d-6fe0-0263-4efeabfd9beb@FreeBSD.org> --o29koHnVcEqidntWU1GWZqJO9ROUgfbX6 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 3/11/2021 9:23 AM, John Baldwin wrote: > On 3/10/21 3:57 AM, Mateusz Guzik wrote: =2E.. > I don't know that we've had so many issues that we can't just fix them = on > HEAD right now vs having to make this a warning instead of keeping it a= s > a panic. >=20 Given this isn't a consistency assertion, a nice temporary mechanism would be to only warn during boot but panic for instances seen after that. Perhaps collecting and spamming the early warnings continually too so they get reported. Then less people are blocked from upgrading or having to deal with boot panics, and may be able to avoid triggering other cases. It's one thing to have INVARIANTS on HEAD and expect everyone to chip in on that, but another to have a prolonged unstable range of commits. just my 2 cents, Bryan --o29koHnVcEqidntWU1GWZqJO9ROUgfbX6-- --aVuFBlAJPYlT86BMcrZFhw1NvKwD0NTlj Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAmBKVbgFAwAAAAAACgkQNddxu25Gl8/r DQgAyXA6GZ/RjOKrEqcb0kSnMLzTdjws/55e+zpjgJTivXbcg4rHxDrsWBriqypHD3QlzaezitD/ uJuO8F5LZq7NizWQ6GaMfiq93L875OS75WtsZo701YDmxChhO4UAantRIS9/V0B1OHaDcKzHMCJy I73mhmYPYoeScTKBDH7Folj4Hvk4Y3o9AkefiAhDDfunIpnzE1tiY9KDgLxTB7edycIaom/FjBRV S10+JSAzB0SNihlPr3229EBh8rd9zK9QTlcKRGcMCM8Ksd8l7U/miAx1MZOGWHkZ/8vUjnSUtbeO PEADeI3nEKu5fmsiRCYlHk7xZJVutHlbx2vi0B1Axw== =Gs8d -----END PGP SIGNATURE----- --aVuFBlAJPYlT86BMcrZFhw1NvKwD0NTlj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9132135e-8653-4df8-984e-c00806e4e533>