Date: Fri, 23 Aug 2019 02:18:22 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 240048] [NEW PORT] net/sems: SIP media server Message-ID: <bug-240048-7788-vIh4g52fnC@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-240048-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-240048-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240048 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nwhitehorn@FreeBSD.org URL| |https://github.com/sems-ser | |ver/sems/ Keywords| |feature, needs-patch, | |needs-qa Status|New |Open Flags| |maintainer-feedback?(nwhite | |horn@FreeBSD.org) Assignee|ports-bugs@FreeBSD.org |nwhitehorn@FreeBSD.org --- Comment #1 from Kubilay Kocak <koobs@FreeBSD.org> --- @Nathan You just need ports committer to review/accept the changes to commit this change yourself. Happy to help with that if you can that QA (at least portlint -AC, poudriere) passes. There's at least a couple of minor ports compliance issues at first glance: - WRKSRC override shouldn't be required with USE_GITHUB/GH_* vars setup correctly +USE_GITHUB=3D yes +GH_ACCOUNT=3D sems-server +GH_TAGNAME=3D 7400051 should be after USES - USES/USE should all be grouped/sorted [1]=20 - Q: DOCSDIR entries contain '1.7.0', this looks like 'real' (possibly pre-release) version of the software (vs g20190822). Given previous release= is 1.6.0 [2], DISTVERSION=3D1.7.0.a<datestamp> or DISTVERSION=3D1.7.0.g<datest= amp> is probably better, as this will allow the future 1.7.0 release version to be > than that version string: # pkg version -t 1.7.0 1.7.0.g20190822 > # pkg version -t 1.7.0 1.7.0.a20190822 > If you'd like to create a phabricator review, add 'contributor reviewers (ports)' (and myself if you like) to the Reviewers list, that should get you the review you need ^Triage: Reporter is (src) committer, assign accordingly [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html [2] https://github.com/sems-server/sems/releases --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240048-7788-vIh4g52fnC>