Date: Wed, 19 Jul 2017 19:00:17 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Dmitry Marakasov <amdmi3@amdmi3.ru> Cc: <rum1cro@yandex.ru>, <ian@freebsd.org>, <kib@freebsd.org>, <freebsd-current@freebsd.org>, <sjg@juniper.net> Subject: Re: [bmake] bmake sigint handling causing tty corruption Message-ID: <88391.1500516017@kaos.jnpr.net> In-Reply-To: <20170718205700.GA2131@hades.panopticon> References: <20170718205700.GA2131@hades.panopticon>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Dmitry Thanks for the detailed report. Will take a look.... > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215572 > Now to fix this, I suggest that instead of killing itself, make should > signal all its childs carefully and wait() on them, only then die > itself. > = > Now after a quick glance at bmake sources it seems like the jobs control > code > = > https://svnweb.freebsd.org/base/head/contrib/bmake/job.c?revision=3D3172= 39&view=3Dmarkup#l2633 > = > does the very same thing that I've just described, however bmake is run > in compat mode by default, and CompatInterrupt does exactly what ktrace > shows - it just kills itself. > = > https://svnweb.freebsd.org/base/head/contrib/bmake/compat.c?revision=3D3= 10304&view=3Dmarkup#l180 > = > So, to fix this problem it seems that CompatInterrupt should be improved > as described above.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?88391.1500516017>