Date: Fri, 3 Dec 2010 14:41:03 +0000 From: Bruce Cran <bruce@cran.org.uk> To: Ivan Voras <ivoras@freebsd.org> Cc: src-committers@freebsd.org, John Baldwin <jhb@freebsd.org>, svn-src-all@freebsd.org, Bruce Evans <brde@optusnet.com.au>, Bruce Cran <brucec@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r216134 - in head: share/man/man9 sys/amd64/include sys/arm/include sys/i386/include sys/ia64/include sys/mips/include sys/pc98/include sys/powerpc/include sys/sparc64/include sys/sun4v... Message-ID: <20101203144103.00005a78@unknown> In-Reply-To: <AANLkTinG%2BD=O0w61EVfAOYVagEXLO7TyB%2BNwdECmx%2BEF@mail.gmail.com> References: <201012022219.oB2MJUx5031472@svn.freebsd.org> <20101203201705.O2228@besplex.bde.org> <20101203101651.7461ced0@core.draftnet> <201012030746.44967.jhb@freebsd.org> <AANLkTinG%2BD=O0w61EVfAOYVagEXLO7TyB%2BNwdECmx%2BEF@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 3 Dec 2010 15:27:13 +0100 Ivan Voras <ivoras@freebsd.org> wrote: > I'd say it depends on if the "specific case that hps raised a few > years ago" sentence part refers to an actual problem; i.e. did it > happen in practice? If yes, leaving KASSERTs looks like the best > option. I've found hps's original email thread, which is at http://lists.freebsd.org/pipermail/freebsd-hackers/2005-June/012342.html . The argument for allowing zero-length reads/writes is at http://lists.freebsd.org/pipermail/freebsd-hackers/2005-June/012348.html . I suspect the mistake occurred due to a misunderstanding of the API. NetBSD have documented it in their man page but not added asserts in the code: "Functions which take a count of bytes have undefined results if the specified count is zero." -- Bruce Cran
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101203144103.00005a78>