Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 09 Oct 2021 06:56:01 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 258107] audio/audacity: Upgrade to 3.0.5
Message-ID:  <bug-258107-7788-ht5OinVEAO@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-258107-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-258107-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258107

Tatsuki Makino <tatsuki_makino@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #228272|0                           |1
        is obsolete|                            |

--- Comment #44 from Tatsuki Makino <tatsuki_makino@hotmail.com> ---
Created attachment 228534
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D228534&action=
=3Dedit
poudriere log run with attachment 228475

(In reply to Jack from comment #43)

Building audacity packages is a success.

In this patch,

The strip in the post-install target is not needed.
bin/${PORTNAME} is still striped in 3.0.5.
lib/${PORTNAME}/modules/mod-script-pipe.so is not stripped in 3.0.5, but
post-install-DEBUG-off target will find it and strip it.
The pattern '*.so*' is used in line 1396 of
audacity-Audacity-3.0.5/src/CMakeLists.txt.

CPPFLAGS and LDFLAGS for lame are written in Makefile, but
cmake-proxies/cmake-modules/Findlibmp3lame.cmake, which is added by the pat=
ch,
can find lame without them.

Also, the empty directory issue written in the post-install target occurs at
the end of the build phase, so I guess that can be moved to the post-build
target.
The reason why there is an empty directory there is because the reason it is
created is not working properly, and I think it is possible to omit the
process.
add_custom_command in line 1313 of audacity-Audacity-3.0.5/src/CMakeLists.t=
xt
executes it.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-258107-7788-ht5OinVEAO>