Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Mar 2018 22:49:06 +0100
From:      Mateusz Guzik <mjguzik@gmail.com>
To:        Mateusz Guzik <mjg@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r330294 - head/sys/kern
Message-ID:  <CAGudoHGwgtUNeaXu761DWB7BYzXsVqj5zwiLYvQ_HoH0v6hW8Q@mail.gmail.com>
In-Reply-To: <201803022126.w22LQRKH034839@repo.freebsd.org>
References:  <201803022126.w22LQRKH034839@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 2, 2018 at 10:26 PM, Mateusz Guzik <mjg@freebsd.org> wrote:

> Author: mjg
> Date: Fri Mar  2 21:26:27 2018
> New Revision: 330294
> URL: https://svnweb.freebsd.org/changeset/base/330294
>
> Log:
>   sx: fix adaptive spinning broken in r327397
>
>   The condition was flipped.
>
>   In particular heavy multithreaded kernel builds on zfs started suffering
>   due to nested sx locks.
>
>   For instance make -s -j 128 buildkernel:
>
>   before: 3326.67s user 1269.62s system 6981% cpu 1:05.84 total
>   after: 3365.55s user 911.27s system 6871% cpu 1:02.24 total
>
>   ps.
>         .-'---`-.                             .-'---`-.
>       ,'          `.                ,'          `.
>       |             \               |             \
>       |              \              |              \
>       \           _  \              \           _  \
>       ,\  _    ,'-,/-)\             ,\  _    ,'-,/-)\
>       ( * \ \,' ,' ,'-)             ( * \ \,' ,' ,'-)
>        `._,)     -',-')              `._,)     -',-')
>          \/         ''/                \/         ''/
>           )        / /                  )        / /
>          /       ,'-'                  /       ,'-'
>

For some reason some people have non-fixed size fonts and keep asking what
this is. It's not a squirrel, Admiral Ackbar nor a failed attempt at ascii
art.

The svnweb version provides a nice view:

https://svnweb.freebsd.org/base?view=revision&revision=330294

Courtesy of http://www.asciifacepalm.com/

-- 
Mateusz Guzik <mjguzik gmail.com>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHGwgtUNeaXu761DWB7BYzXsVqj5zwiLYvQ_HoH0v6hW8Q>