Date: Fri, 4 May 2018 11:28:33 -0600 From: Sean Bruno <sbruno@freebsd.org> To: "K. Macy" <kmacy@freebsd.org>, rgrimes@freebsd.org Cc: Matt Macy <mmacy@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r333242 - head/sys/kern Message-ID: <715d0d1b-d71e-b190-7855-a0d3dc6c7212@freebsd.org> In-Reply-To: <CAHM0Q_MiY00rFTqh%2BA1hp9a7Jxo5bVRKQu%2B-2TBbekkknyjeaw@mail.gmail.com> References: <201805040651.w446p2iB010839@repo.freebsd.org> <201805041407.w44E7EHg042498@pdx.rh.CN85.dnsmgr.net> <CAHM0Q_MiY00rFTqh%2BA1hp9a7Jxo5bVRKQu%2B-2TBbekkknyjeaw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wvbWc5rwFoJQweoYQu6rFMvvKpZunD1jW Content-Type: multipart/mixed; boundary="YmTKEIzqwR4oR3SPw0ECbsOf8HMHLkqgO"; protected-headers="v1" From: Sean Bruno <sbruno@freebsd.org> To: "K. Macy" <kmacy@freebsd.org>, rgrimes@freebsd.org Cc: Matt Macy <mmacy@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Message-ID: <715d0d1b-d71e-b190-7855-a0d3dc6c7212@freebsd.org> Subject: Re: svn commit: r333242 - head/sys/kern References: <201805040651.w446p2iB010839@repo.freebsd.org> <201805041407.w44E7EHg042498@pdx.rh.CN85.dnsmgr.net> <CAHM0Q_MiY00rFTqh+A1hp9a7Jxo5bVRKQu+-2TBbekkknyjeaw@mail.gmail.com> In-Reply-To: <CAHM0Q_MiY00rFTqh+A1hp9a7Jxo5bVRKQu+-2TBbekkknyjeaw@mail.gmail.com> --YmTKEIzqwR4oR3SPw0ECbsOf8HMHLkqgO Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable For the "official" record: Approved-by: sbruno :-) sean p.s. silly svn didn't stop this commit, I wonder why. On 05/04/18 10:20, K. Macy wrote: > Yes. Good catch. Thanks. >=20 > -M >=20 >> >> Missing Approved by: sbruno? >> >> >>> Modified: >>> head/sys/kern/kern_descrip.c >>> >>> Modified: head/sys/kern/kern_descrip.c >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/sys/kern/kern_descrip.c Fri May 4 04:05:07 2018 = (r333241) >>> +++ head/sys/kern/kern_descrip.c Fri May 4 06:51:01 2018 = (r333242) >>> @@ -1503,7 +1503,7 @@ filecaps_copy(const struct filecaps *src, struc= t filec >>> >>> if (src->fc_ioctls !=3D NULL && !locked) >>> return (false); >>> - *dst =3D *src; >>> + memcpy(dst, src, sizeof(*src)); >>> if (src->fc_ioctls =3D=3D NULL) >>> return (true); >>> >>> @@ -1512,7 +1512,7 @@ filecaps_copy(const struct filecaps *src, struc= t filec >>> >>> size =3D sizeof(src->fc_ioctls[0]) * src->fc_nioctls; >>> dst->fc_ioctls =3D malloc(size, M_FILECAPS, M_WAITOK); >>> - bcopy(src->fc_ioctls, dst->fc_ioctls, size); >>> + memcpy(dst->fc_ioctls, src->fc_ioctls, size); >>> return (true); >>> } >>> >>> >>> >> >> -- >> Rod Grimes rgrimes@fre= ebsd.org >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org= " >=20 >=20 --YmTKEIzqwR4oR3SPw0ECbsOf8HMHLkqgO-- --wvbWc5rwFoJQweoYQu6rFMvvKpZunD1jW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGSBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlrsmEFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LY8Kwf4uEIE7xaBLzSrBoflWhI2CzoqlbwCqyszDanZEFf3burxecM5oCKMJkt1 4RNXfWDviKV83C+70068IVrA0NnRYUFYgbzf6L8Z7reytJ21rapyTzUKytwJV3eT BQw0a8yzsT9tJh6f3iy6OyTOPxya/HKhya8wVMhGGkijQ6pPO13euAEWS9ZhGk6o wt0T+fGLWh04Qew0fruAspA2DucWNz2w4pBEyYE6KZpYCpt4ZAQupXBrmbtLBDqP MFULnmzWDIcfx0xcJx3E4x4XNjTSZpf41MWInoZ6T2yXXyWrCHGvwGt5AGLxWsv3 CNx1NvwbHdwl68UXewgANGwGlwi9 =pNCp -----END PGP SIGNATURE----- --wvbWc5rwFoJQweoYQu6rFMvvKpZunD1jW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?715d0d1b-d71e-b190-7855-a0d3dc6c7212>