Date: Sun, 15 Apr 2007 07:47:31 -0400 From: Randall Stewart <rrs@cisco.com> To: Max Laier <max@love2party.net> Cc: rrs@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet sctp_indata.c Message-ID: <462210D3.8040000@cisco.com> In-Reply-To: <200704142031.02804.max@love2party.net> References: <200704141827.l3EIRYJM049804@repoman.freebsd.org> <200704142031.02804.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Max Laier wrote: > On Saturday 14 April 2007 20:27, Max Laier wrote: >> mlaier 2007-04-14 18:27:34 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet sctp_indata.c >> Log: >> Fix a typeo - unbreak the build. > > While checking this, I came across the fact that SCTP_SACK_LOGGING depends > on SCTP_STATS_LOGGING. Not sure if that's intended, but it's fixable > with a bit of shuffling in sctputil.c/h > >> Revision Changes Path >> 1.16 +1 -1 src/sys/netinet/sctp_indata.c > Hmm.. well all of the logging is dependant on this. In order to do any logging one must enable SCTP_STATS_LOGGING.. this gets all the allocations and stuff in place. Hmm.. one thing we could do is make it so if you enable any of the loggings STATS_LOGGING gets enabled. Thanks for fixing the typo :-0 I have been offline with the storm for a bit (and a honey do list yesterday) :-0 Hmm let me go add the logging ifdefs to sctputil.h R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 <or> 803-317-4952 (cell)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?462210D3.8040000>