Date: Thu, 14 Jul 2016 10:46:53 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: "Conrad E. Meyer" <cem@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r418510 - head/devel/elfutils Message-ID: <20160714084653.quyjmu7g3e4f7d5b@ivaldir.etoilebsd.net> In-Reply-To: <201607140142.u6E1g9Sp056312@repo.freebsd.org> References: <201607140142.u6E1g9Sp056312@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--d4bn2je3ahvy6sw6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 14, 2016 at 01:42:09AM +0000, Conrad E. Meyer wrote: > Author: cem (src committer) > Date: Thu Jul 14 01:42:09 2016 > New Revision: 418510 > URL: https://svnweb.freebsd.org/changeset/ports/418510 >=20 > Log: > elfutils: > =20 > - Add automake BUILD_DEPEND because apparently USE_AUTOTOOLS=3Dautomake= doesn't. > - Add dependency on yet-to-be-committed base ELF header structures. Wi= thout > them, the library portion of the port isn't very useful. >=20 Which is exactly why non ports committers are not supposed to commit in the= ports tree without a ports committer review/approval. At least at quick glance there is this: - post-patch expects gnulib to already be installed but gnulib is a build dependency and not a patch dependency so not installed at the momemt you needed it - automake is not supposed to be run like this https://people.freebsd.org/~bapt/elfutils.diff Should fix those 2 issues Bapt --d4bn2je3ahvy6sw6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXh1F6AAoJEGOJi9zxtz5aKfcQAIpyS8FClt4ZV2mpvlOG6bs3 H3ewxxvUDD2/quzKZYfYpTNjilGl2mmykX5b8I1+8tPgg596YsIN1jiJ/fLkxMa0 eS6elf+MC7EooiRZSwC06/v/9eiCaMUVd7KnR1m3w0+P4mgYX7mWkR+XPxKvZ0zu nl0Mz/nIiMlv/J0f52QWs3LBLQXCYUTaPV4RDJ1gPhIYsguZaXQiKjb1sDyGwhaw eRYD1cTykHrZOa/zWJHmXGLSG3JyhaSR6QBIjg5xiloe6J6STnfW8bxZEunLNqUi m3Zvw1gK+kAUqTxpWw1pMZkDHdRG5zTvA9CC9S321GHy/sXsRP1lP/QqxON708l8 3poy1+w7uJ7WeYnN9HHqwDY71DNPkiOrrmbygVs9BQkxXy1qkHNvK5wVdM/dHTA5 Z2X182q1Xwe0EX5HMSwlI77cKD83hP8aq083j/y2mhSjHkSOrHhQ0woJGKg4qYUR GlaTK9JPYEHwscWbqrSA5ViHZ1SYYFBLZXUSfzmvbxVn50IJ3gQTM6mrOlxvMj5q 7/fAlswU3sg2kOS0hYii5mS7Nx/8Xu0IHe37ChpzQX019FEFbtzwhmOXQc6utyPB H7yDnYpDNnPZ9G8mciKSQAB/vAw3BC2kMIZsE7egYtKeqOuWF5EQBnQp9AYNp5WV Jc6wD/hPeN2yRQt7JRWS =y+oN -----END PGP SIGNATURE----- --d4bn2je3ahvy6sw6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160714084653.quyjmu7g3e4f7d5b>