Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Dec 2018 21:11:18 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 233993] mail/mutt extra patch patches do not apply cleanly if QUOTE_PATCH is not selected
Message-ID:  <bug-233993-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233993

            Bug ID: 233993
           Summary: mail/mutt extra patch patches do not apply cleanly if
                    QUOTE_PATCH is not selected
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: mjl@luckie.org.nz
                CC: dereks@lifeofadishwasher.com
             Flags: maintainer-feedback?(dereks@lifeofadishwasher.com)
                CC: dereks@lifeofadishwasher.com

Created attachment 200091
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200091&action=
=3Dedit
remove patch context that prevents building

I was unable to build mutt, because it failed to apply the extra-patch-ifdef
file.  Specifically, the patch is aborting because of the modification in
/usr/ports/mail/mutt/files/extra-patch-ifdef to the PATCHES file.

=3D=3D=3D>  Patching for mutt-1.11.1
=3D=3D=3D>  Applying extra patch /usr/ports/mail/mutt/files/extra-patch-asp=
ell
=3D=3D=3D>  Applying extra patch /usr/ports/mail/mutt/files/extra-patch-ifd=
ef
1 out of 1 hunks failed--saving rejects to PATCHES.rej

The issue is that I did not have QUOTE_PATCH configured, so PATCHES did not
have the content that the extra-patch-ifdef and extra-patch-reverse_reply
patches assumed would be there to apply against.  I think the fix is to rem=
ove
the patch context, like some of the other patches in mail/mutt/files.

The attached patch works for me, and seems to be similar to the approach ta=
ken
in revision 474718 for extra-patch-reverse_reply.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233993-7788>