Date: Thu, 30 Mar 2017 23:07:50 +0000 From: "Somayajulu, David" <David.Somayajulu@cavium.com> To: hiren panchasara <hiren@strugglingcoder.info>, David C Somayajulu <davidcs@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: RE: svn commit: r316309 - head/sys/dev/qlxgbe Message-ID: <BY2PR07MB14744C383EA86B3EA1F3927CEE340@BY2PR07MB1474.namprd07.prod.outlook.com> In-Reply-To: <20170330230227.GH1016@strugglingcoder.info> References: <201703302243.v2UMhX2s011405@repo.freebsd.org> <20170330230227.GH1016@strugglingcoder.info>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Hiren, > I know this is not a new topic but a little more descriptive commit-log w= ould have been nicer. Also, you should update the manpage reflecting this c= hange. i.e. now it also supports software LRO when h/w LRO is disabled. Will do. Sorry about that. > Do you know of a case where one would want to disable h/w lro and enable = s/w lro? I guess where you want to free up nic and make cpu do more work? I was under the impression as well, that s/w lro is moot, if h/w lro was av= ailable, till one costumer asked for it. Not sure what the use case is. Thanks David S. -----Original Message----- From: hiren panchasara [mailto:hiren@strugglingcoder.info]=20 Sent: Thursday, March 30, 2017 4:02 PM To: David C Somayajulu <davidcs@FreeBSD.org> Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freeb= sd.org Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe On 03/30/17 at 10:43P, David C Somayajulu wrote: > Author: davidcs > Date: Thu Mar 30 22:43:32 2017 > New Revision: 316309 > URL: https://svnweb.freebsd.org/changeset/base/316309 >=20 > Log: > Add support for optional Soft LRO Hi David, I know this is not a new topic but a little more descriptive commit-log wou= ld have been nicer. Also, you should update the manpage reflecting this cha= nge. i.e. now it also supports software LRO when h/w LRO is disabled. Do you know of a case where one would want to disable h/w lro and enable s/= w lro? I guess where you want to free up nic and make cpu do more work? Cheers, Hiren
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BY2PR07MB14744C383EA86B3EA1F3927CEE340>