Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 May 2021 16:04:12 GMT
From:      Emmanuel Vadot <manu@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: bc1bb80564ee - main - arm64: rockchip: gpio: Give friendlier name to gpio
Message-ID:  <202105211604.14LG4Ci0005046@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by manu:

URL: https://cgit.FreeBSD.org/src/commit/?id=bc1bb80564eef66cef1a7b9791af87ae019aa71d

commit bc1bb80564eef66cef1a7b9791af87ae019aa71d
Author:     Emmanuel Vadot <manu@FreeBSD.org>
AuthorDate: 2021-05-16 12:47:16 +0000
Commit:     Emmanuel Vadot <manu@FreeBSD.org>
CommitDate: 2021-05-21 15:35:43 +0000

    arm64: rockchip: gpio: Give friendlier name to gpio
    
    By default name the gpio P<bank><bankpin>
    This make it easier to find the gpio when reading schematics or DTS.
    
    Sponsored by:   Diablotin Systems
    Differential Revision:  https://reviews.freebsd.org/D30287
---
 sys/arm64/rockchip/rk_gpio.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sys/arm64/rockchip/rk_gpio.c b/sys/arm64/rockchip/rk_gpio.c
index aa44a6bc9e09..d3623b2302ec 100644
--- a/sys/arm64/rockchip/rk_gpio.c
+++ b/sys/arm64/rockchip/rk_gpio.c
@@ -209,14 +209,17 @@ static int
 rk_gpio_pin_getname(device_t dev, uint32_t pin, char *name)
 {
 	struct rk_gpio_softc *sc;
+	uint32_t bank;
 
 	sc = device_get_softc(dev);
 
 	if (pin >= 32)
 		return (EINVAL);
 
+	bank = pin / 8;
+	pin = pin - (bank * 8);
 	RK_GPIO_LOCK(sc);
-	snprintf(name, GPIOMAXNAME, "gpio%d", pin);
+	snprintf(name, GPIOMAXNAME, "P%c%d", bank + 'A', pin);
 	RK_GPIO_UNLOCK(sc);
 
 	return (0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105211604.14LG4Ci0005046>