Date: Thu, 18 Jun 2009 10:03:18 -0500 From: Brooks Davis <brooks@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: svn-src-projects@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r194389 - projects/ngroups/sys/kern Message-ID: <20090618150318.GD46033@lor.one-eyed-alien.net> In-Reply-To: <4A3A10D5.8000601@freebsd.org> References: <200906171940.n5HJerMr086037@svn.freebsd.org> <4A3A10D5.8000601@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0H629O+sVkh21xTi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 18, 2009 at 01:03:01PM +0300, Andriy Gapon wrote: > on 17/06/2009 22:40 Brooks Davis said the following: > > Author: brooks > > Date: Wed Jun 17 19:40:53 2009 > > New Revision: 194389 > > URL: http://svn.freebsd.org/changeset/base/194389 > >=20 > > Log: > > use MIN() instead of min() in one case. >=20 > I think 'what' was pretty obvious from the diff, 'why' is what I am curio= us about :-) > Just trying to learn something. Because the file already used MIN and all the other cases in the system that involve some form on ngroups also use MIN. -- Brooks > > Modified: > > projects/ngroups/sys/kern/kern_prot.c > >=20 > > Modified: projects/ngroups/sys/kern/kern_prot.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- projects/ngroups/sys/kern/kern_prot.c Wed Jun 17 19:01:47 2009 (r19= 4388) > > +++ projects/ngroups/sys/kern/kern_prot.c Wed Jun 17 19:40:53 2009 (r19= 4389) > > @@ -1899,7 +1899,7 @@ cru2x(struct ucred *cr, struct xucred *x > > xcr->cr_version =3D XUCRED_VERSION; > > xcr->cr_uid =3D cr->cr_uid; > > =20 > > - ngroups =3D min(cr->cr_ngroups, XU_NGROUPS); > > + ngroups =3D MIN(cr->cr_ngroups, XU_NGROUPS); > > xcr->cr_ngroups =3D ngroups; > > bcopy(cr->cr_groups, xcr->cr_groups, > > ngroups * sizeof(*cr->cr_groups)); >=20 >=20 > --=20 > Andriy Gapon >=20 --0H629O+sVkh21xTi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFKOlc2XY6L6fI4GtQRAkq0AKDVtN4yznD7m38XRyhSk97hTscDLgCfaGSA 5nfjVoHID0RYaCixdNb2eNg= =JUT4 -----END PGP SIGNATURE----- --0H629O+sVkh21xTi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090618150318.GD46033>