Date: Tue, 28 Sep 2021 03:47:54 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: =?UTF-8?B?U3RlZmFuIEXDn2Vy?= <se@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: a642f92e86d3 - main - misc/py-pexpect: fix most of the test cases Message-ID: <CAMHz58R5qeCxpQqmLcFN5GgFk2UzcjZCOXJ_R8U0DFn=vGFaDg@mail.gmail.com> In-Reply-To: <202109271550.18RFoZuU023509@gitrepo.freebsd.org> References: <202109271550.18RFoZuU023509@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Sep 27, 2021 at 11:50 PM Stefan E=C3=9Fer <se@freebsd.org> wrote: > The branch main has been updated by se: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Da642f92e86d3b022e67d99f1c1dbd= 9fe6499c634 > > commit a642f92e86d3b022e67d99f1c1dbd9fe6499c634 > Author: Stefan E=C3=9Fer <se@FreeBSD.org> > AuthorDate: 2021-09-27 13:49:11 +0000 > Commit: Stefan E=C3=9Fer <se@FreeBSD.org> > CommitDate: 2021-09-27 15:49:50 +0000 > > misc/py-pexpect: fix most of the test cases > > A number of test cases included in the pexpect distribution failed on > FreeBSD. The patches included in the commit fix most of these tests. > > One of the tests used /bin/bash and long options for the nl command. > Other tests assumed pipe buffers larger than provided by FreeBSD. > > 3 tests are still failing: > > tests/test_replwrap.py::REPLWrapTestCase::test_existing_spawn FAILED > > The text received contains bracketed paste escape characters when > a bash version 5.1 or newer is installed. There may be another proble= m > with this test, though, since it seems to depend on some bash rc file > of the account executing this test. > > tests/test_socket.py::ExpectTestCase::test_interrupt FAILED > tests/test_socket.py::ExpectTestCase::test_multiple_interrupts FAILED > > These two test seem to fail due to an early exit of the sending > process. It appears to be in Zombie state and cannot be signaled. > The "non-blocking read" seems to be blocking in this situation. > > The real cause is unclear, it seems to be a mismatch between process > lifetime semantics in Linux and FreeBSD. I have removed an infinite > wait loop with these patches, which causes a test failure to be > detected (instead of preventing the execution of any further test > cases). > > I have created a pull request on Github to get these patches into the > upstream, but it seems that the owner of the pexpect repository is no= t > very active. > > Approved by: sunpoet (maintainer) > Stefan, thanks for fixing it! Regards, sunpoet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58R5qeCxpQqmLcFN5GgFk2UzcjZCOXJ_R8U0DFn=vGFaDg>