Date: Tue, 1 Oct 2013 05:48:32 +0900 From: Takuya ASADA <syuu@dokukino.com> To: hiren panchasara <hiren.panchasara@gmail.com> Cc: FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: Flow Director statistics for ixgbe(4) Message-ID: <CALG4x-V3VpqVoDwinvphRHH8akeo2harrKWHK%2BHRV8JOMsWbrQ@mail.gmail.com> In-Reply-To: <CALCpEUGkjMXdFFdU-NzXMZ9nonB4PttJm7MBqtvqUHn8ertJXA@mail.gmail.com> References: <CALG4x-W302xOS0P3580UCdJaTDsKq5NiZgcoFBi2jyv9CoQ3%2Bw@mail.gmail.com> <CALCpEUGkjMXdFFdU-NzXMZ9nonB4PttJm7MBqtvqUHn8ertJXA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--047d7b10c9650aebb104e79ff868 Content-Type: text/plain; charset=UTF-8 Hi, descriptions are added. 2013/10/1 hiren panchasara <hiren.panchasara@gmail.com> > > > > On Mon, Sep 30, 2013 at 12:02 PM, Takuya ASADA <syuu@dokukino.com> wrote: > >> Hi, >> >> This is originally part of "ixgbetool" patch, but I think it can be >> discuss >> separately: >> >> http://freebsd.1045724.n5.nabble.com/Adding-Flow-Director-sysctls-to-ixgbe-4-was-netmap-traffic-distribution-tp5847066p5847789.html >> >> I implemented sysctls to expose Flow Director statistics. >> It works like this: >> $ sysctl dev.ix.0.mac_stats|grep fdir >> dev.ix.0.mac_stats.fdirfree_free: 8192 >> dev.ix.0.mac_stats.fdirfree_coll: 0 >> dev.ix.0.mac_stats.fdirustat_add: 0 >> dev.ix.0.mac_stats.fdirustat_remove: 0 >> dev.ix.0.mac_stats.fdirfstat_fadd: 0 >> dev.ix.0.mac_stats.fdirfstat_fremove: 0 >> dev.ix.0.mac_stats.fdirmatch: 0 >> dev.ix.0.mac_stats.fdirmiss: 23 >> > > I am running this with the ixgbetool patch you have and only 1 issue I've > seen so far: fdirustat_add increments on adding a filter but > fdirustat_remove does not on deleting one (if thats how its supposed to > work) > > Can you please populate "description" for all the sysctls you are adding? > :-) > > Cheers, > Hiren > --047d7b10c9650aebb104e79ff868 Content-Type: application/octet-stream; name="fdirsysctl-v002.diff" Content-Disposition: attachment; filename="fdirsysctl-v002.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hm865x2o0 ZGlmZiAtLWdpdCBhL3N5cy9kZXYvaXhnYmUvaXhnYmUuYyBiL3N5cy9kZXYvaXhnYmUvaXhnYmUu YwppbmRleCBiNjVkZjcyLi5mOGEyYTlmIDEwMDY0NAotLS0gYS9zeXMvZGV2L2l4Z2JlL2l4Z2Jl LmMKKysrIGIvc3lzL2Rldi9peGdiZS9peGdiZS5jCkBAIC01MjcwLDEzICs1MjcwLDMzIEBAIGl4 Z2JlX3VwZGF0ZV9zdGF0c19jb3VudGVycyhzdHJ1Y3QgYWRhcHRlciAqYWRhcHRlcikKIAlhZGFw dGVyLT5zdGF0cy54ZWMgKz0gSVhHQkVfUkVBRF9SRUcoaHcsIElYR0JFX1hFQyk7CiAJYWRhcHRl ci0+c3RhdHMuZmNjcmMgKz0gSVhHQkVfUkVBRF9SRUcoaHcsIElYR0JFX0ZDQ1JDKTsKIAlhZGFw dGVyLT5zdGF0cy5mY2xhc3QgKz0gSVhHQkVfUkVBRF9SRUcoaHcsIElYR0JFX0ZDTEFTVCk7Ci0J LyogT25seSByZWFkIEZDT0Ugb24gODI1OTkgKi8KKwkvKiBPbmx5IHJlYWQgRkNPRS9GRElSIG9u IDgyNTk5ICovCiAJaWYgKGh3LT5tYWMudHlwZSAhPSBpeGdiZV9tYWNfODI1OThFQikgewogCQlh ZGFwdGVyLT5zdGF0cy5mY29lcnBkYyArPSBJWEdCRV9SRUFEX1JFRyhodywgSVhHQkVfRkNPRVJQ REMpOwogCQlhZGFwdGVyLT5zdGF0cy5mY29lcHJjICs9IElYR0JFX1JFQURfUkVHKGh3LCBJWEdC RV9GQ09FUFJDKTsKIAkJYWRhcHRlci0+c3RhdHMuZmNvZXB0YyArPSBJWEdCRV9SRUFEX1JFRyho dywgSVhHQkVfRkNPRVBUQyk7CiAJCWFkYXB0ZXItPnN0YXRzLmZjb2Vkd3JjICs9IElYR0JFX1JF QURfUkVHKGh3LCBJWEdCRV9GQ09FRFdSQyk7CiAJCWFkYXB0ZXItPnN0YXRzLmZjb2Vkd3RjICs9 IElYR0JFX1JFQURfUkVHKGh3LCBJWEdCRV9GQ09FRFdUQyk7CisJCWFkYXB0ZXItPnN0YXRzLmZk aXJmcmVlX2ZyZWUgPQorCQkJKElYR0JFX1JFQURfUkVHKGh3LCBJWEdCRV9GRElSRlJFRSkgJiBJ WEdCRV9GRElSRlJFRV9GUkVFX01BU0spCisJCQk+PiBJWEdCRV9GRElSRlJFRV9GUkVFX1NISUZU OworCQlhZGFwdGVyLT5zdGF0cy5mZGlyZnJlZV9jb2xsID0KKwkJCShJWEdCRV9SRUFEX1JFRyho dywgSVhHQkVfRkRJUkZSRUUpICYgSVhHQkVfRkRJUkZSRUVfQ09MTF9NQVNLKQorCQkJPj4gSVhH QkVfRkRJUkZSRUVfQ09MTF9TSElGVDsKKwkJYWRhcHRlci0+c3RhdHMuZmRpcnVzdGF0X2FkZCAr PQorCQkJKElYR0JFX1JFQURfUkVHKGh3LCBJWEdCRV9GRElSVVNUQVQpICYgSVhHQkVfRkRJUlVT VEFUX0FERF9NQVNLKQorCQkJPj4gSVhHQkVfRkRJUlVTVEFUX0FERF9TSElGVDsKKwkJYWRhcHRl ci0+c3RhdHMuZmRpcnVzdGF0X3JlbW92ZSArPQorCQkJKElYR0JFX1JFQURfUkVHKGh3LCBJWEdC RV9GRElSVVNUQVQpICYgSVhHQkVfRkRJUlVTVEFUX1JFTU9WRV9NQVNLKQorCQkJPj4gSVhHQkVf RkRJUlVTVEFUX1JFTU9WRV9TSElGVDsKKwkJYWRhcHRlci0+c3RhdHMuZmRpcmZzdGF0X2ZhZGQg Kz0KKwkJCShJWEdCRV9SRUFEX1JFRyhodywgSVhHQkVfRkRJUkZTVEFUKSAmIElYR0JFX0ZESVJG U1RBVF9GQUREX01BU0spCisJCQk+PiBJWEdCRV9GRElSRlNUQVRfRkFERF9TSElGVDsKKwkJYWRh cHRlci0+c3RhdHMuZmRpcmZzdGF0X2ZyZW1vdmUgKz0KKwkJCShJWEdCRV9SRUFEX1JFRyhodywg SVhHQkVfRkRJUkZTVEFUKSAmIElYR0JFX0ZESVJGU1RBVF9GUkVNT1ZFX01BU0spCisJCQk+PiBJ WEdCRV9GRElSRlNUQVRfRlJFTU9WRV9TSElGVDsKKwkJYWRhcHRlci0+c3RhdHMuZmRpcm1hdGNo ICs9IElYR0JFX1JFQURfUkVHKGh3LCBJWEdCRV9GRElSTUFUQ0gpOworCQlhZGFwdGVyLT5zdGF0 cy5mZGlybWlzcyArPSBJWEdCRV9SRUFEX1JFRyhodywgSVhHQkVfRkRJUk1JU1MpOwogCX0KIAog CS8qIEZpbGwgb3V0IHRoZSBPUyBzdGF0aXN0aWNzIHN0cnVjdHVyZSAqLwpAQCAtNTY0Miw2ICs1 NjYyLDMyIEBAIGl4Z2JlX2FkZF9od19zdGF0cyhzdHJ1Y3QgYWRhcHRlciAqYWRhcHRlcikKIAlT WVNDVExfQUREX1VRVUFEKGN0eCwgc3RhdF9saXN0LCBPSURfQVVUTywgInR4X2ZyYW1lc18xMDI0 XzE1MjIiLAogCQkJQ1RMRkxBR19SRCwgJnN0YXRzLT5wdGMxNTIyLAogCQkJIjEwMjQtMTUyMiBi eXRlIGZyYW1lcyB0cmFuc21pdHRlZCIpOworCisJLyogZmRpciBzdGF0cyAqLworCVNZU0NUTF9B RERfVVFVQUQoY3R4LCBzdGF0X2xpc3QsIE9JRF9BVVRPLCAiZmRpcmZyZWVfZnJlZSIsCisJCUNU TEZMQUdfUkQsICZzdGF0cy0+ZmRpcmZyZWVfZnJlZSwKKwkJIk51bWJlciBvZiBmcmVlIGZpbHRl cnMiKTsKKwlTWVNDVExfQUREX1VRVUFEKGN0eCwgc3RhdF9saXN0LCBPSURfQVVUTywgImZkaXJm cmVlX2NvbGwiLAorCQlDVExGTEFHX1JELCAmc3RhdHMtPmZkaXJmcmVlX2NvbGwsCisJCSJOdW1i ZXIgb2YgZmlsdGVycyB3aXRoIGNvbGxpc2lvbiBpbmRpY2F0aW9uIik7CisJU1lTQ1RMX0FERF9V UVVBRChjdHgsIHN0YXRfbGlzdCwgT0lEX0FVVE8sICJmZGlydXN0YXRfYWRkIiwKKwkJQ1RMRkxB R19SRCwgJnN0YXRzLT5mZGlydXN0YXRfYWRkLAorCQkiTnVtYmVyIG9mIGFkZGVkIGZpbHRlcnMi KTsKKwlTWVNDVExfQUREX1VRVUFEKGN0eCwgc3RhdF9saXN0LCBPSURfQVVUTywgImZkaXJ1c3Rh dF9yZW1vdmUiLAorCQlDVExGTEFHX1JELCAmc3RhdHMtPmZkaXJ1c3RhdF9yZW1vdmUsCisJCSJO dW1iZXIgb2YgcmVtb3ZlZCBmaWx0ZXJzIik7CisJU1lTQ1RMX0FERF9VUVVBRChjdHgsIHN0YXRf bGlzdCwgT0lEX0FVVE8sICJmZGlyZnN0YXRfZmFkZCIsCisJCUNUTEZMQUdfUkQsICZzdGF0cy0+ ZmRpcmZzdGF0X2ZhZGQsCisJCSJOdW1iZXIgb2YgZmlsdGVycyBhZGRpdGlvbiBldmVudHMgdGhh dCBkbyBub3QgY2hhbmdlIHRoZSBudW1iZXIgb2YgZnJlZSIpOworCVNZU0NUTF9BRERfVVFVQUQo Y3R4LCBzdGF0X2xpc3QsIE9JRF9BVVRPLCAiZmRpcmZzdGF0X2ZyZW1vdmUiLAorCQlDVExGTEFH X1JELCAmc3RhdHMtPmZkaXJmc3RhdF9mcmVtb3ZlLAorCQkiTnVtYmVyIG9mIGZhaWxlZCByZW1v dmVkIGZpbHRlcnMiKTsKKwlTWVNDVExfQUREX1VRVUFEKGN0eCwgc3RhdF9saXN0LCBPSURfQVVU TywgImZkaXJtYXRjaCIsCisJCUNUTEZMQUdfUkQsICZzdGF0cy0+ZmRpcm1hdGNoLAorCQkiTnVt YmVyIG9mIHBhY2tldHMgdGhhdCBtYXRjaGVkIGFueSBmbG93IGRpcmVjdG9yIGZpbHRlciIpOwor CVNZU0NUTF9BRERfVVFVQUQoY3R4LCBzdGF0X2xpc3QsIE9JRF9BVVRPLCAiZmRpcm1pc3MiLAor CQlDVExGTEFHX1JELCAmc3RhdHMtPmZkaXJtaXNzLAorCQkiTnVtYmVyIG9mIHBhY2tldHMgdGhh dCBtaXNzZWQgbWF0Y2hlZCBhbnkgZmxvdyBkaXJlY3RvciBmaWx0ZXIiKTsKIH0KIAogLyoKZGlm ZiAtLWdpdCBhL3N5cy9kZXYvaXhnYmUvaXhnYmVfODI1OTkuYyBiL3N5cy9kZXYvaXhnYmUvaXhn YmVfODI1OTkuYwppbmRleCAzY2M4Y2Q3Li4yYjEyZjcwIDEwMDY0NAotLS0gYS9zeXMvZGV2L2l4 Z2JlL2l4Z2JlXzgyNTk5LmMKKysrIGIvc3lzL2Rldi9peGdiZS9peGdiZV84MjU5OS5jCkBAIC0x NDgyLDcgKzE0ODIsOCBAQCBzMzIgaXhnYmVfaW5pdF9mZGlyX3NpZ25hdHVyZV84MjU5OShzdHJ1 Y3QgaXhnYmVfaHcgKmh3LCB1MzIgZmRpcmN0cmwpCiAJICogIFNldCB0aGUgbWF4aW11bSBsZW5n dGggcGVyIGhhc2ggYnVja2V0IHRvIDB4QSBmaWx0ZXJzCiAJICogIFNlbmQgaW50ZXJydXB0IHdo ZW4gNjQgZmlsdGVycyBhcmUgbGVmdAogCSAqLwotCWZkaXJjdHJsIHw9ICgweDYgPDwgSVhHQkVf RkRJUkNUUkxfRkxFWF9TSElGVCkgfAorCWZkaXJjdHJsIHw9IElYR0JFX0ZESVJDVFJMX1JFUE9S VF9TVEFUVVMgfAorIAkJICAgICgweDYgPDwgSVhHQkVfRkRJUkNUUkxfRkxFWF9TSElGVCkgfAog CQkgICAgKDB4QSA8PCBJWEdCRV9GRElSQ1RSTF9NQVhfTEVOR1RIX1NISUZUKSB8CiAJCSAgICAo NCA8PCBJWEdCRV9GRElSQ1RSTF9GVUxMX1RIUkVTSF9TSElGVCk7CiAKZGlmZiAtLWdpdCBhL3N5 cy9kZXYvaXhnYmUvaXhnYmVfdHlwZS5oIGIvc3lzL2Rldi9peGdiZS9peGdiZV90eXBlLmgKaW5k ZXggNDlmNWJjMC4uYzVmMjliYiAxMDA2NDQKLS0tIGEvc3lzL2Rldi9peGdiZS9peGdiZV90eXBl LmgKKysrIGIvc3lzL2Rldi9peGdiZS9peGdiZV90eXBlLmgKQEAgLTI5OTcsNiArMjk5Nyw4IEBA IHN0cnVjdCBpeGdiZV9od19zdGF0cyB7CiAJdTY0IHFidGNbMTZdOwogCXU2NCBxcHJkY1sxNl07 CiAJdTY0IHB4b24yb2ZmY1s4XTsKKwl1NjQgZmRpcmZyZWVfZnJlZTsKKwl1NjQgZmRpcmZyZWVf Y29sbDsKIAl1NjQgZmRpcnVzdGF0X2FkZDsKIAl1NjQgZmRpcnVzdGF0X3JlbW92ZTsKIAl1NjQg ZmRpcmZzdGF0X2ZhZGQ7Cg== --047d7b10c9650aebb104e79ff868--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALG4x-V3VpqVoDwinvphRHH8akeo2harrKWHK%2BHRV8JOMsWbrQ>