Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Mar 2012 19:44:11 -0800
From:      Adrian Chadd <adrian@freebsd.org>
To:        Patrick Kelsey <kelsey@ieee.org>
Cc:        freebsd-mips@freebsd.org
Subject:   Re: [PATCH] MikroTik RB450G support
Message-ID:  <CAJ-VmomZiutERg4YcTDUCAOC9Wwx5Gsdei4E-iSvszAw6H81SQ@mail.gmail.com>
In-Reply-To: <CAD44qMV=PEv3DFU7z1S=UhOYO3YMi7zqg7rsjn1zByTpN7ZxgA@mail.gmail.com>
References:  <CAD44qMV=PEv3DFU7z1S=UhOYO3YMi7zqg7rsjn1zByTpN7ZxgA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi!

Thanks for this!

The arge patch for board info should be something chip specific,
rather than always compiled in.

The board model thing should be an environment variable, rather than
hard-coded in the driver.  What's it needed for, anyway? Are the MAC
addresses reversed?

The MII speed thing is good, I've been wondering about adding more MII
config stuff to the ar71xx code. But we'll have to ensure it's set
correctly for the AR91xx and AR724x code.


Adrian



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomZiutERg4YcTDUCAOC9Wwx5Gsdei4E-iSvszAw6H81SQ>