Date: Sun, 25 Mar 2018 20:54:50 +0000 From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-feedback requested: [Bug 226926] [PATCH] Tools/scripts/bump-revision.sh lack a safety belt Message-ID: <bug-226926-12827-of0wjbLt7k@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-226926-12827@https.bugs.freebsd.org/bugzilla/> References: <bug-226926-12827@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Bugzilla Automation <bugzilla@FreeBSD.org> has asked multimedia@FreeBSD.org= for maintainer-feedback: Bug 226926: [PATCH] Tools/scripts/bump-revision.sh lack a safety belt https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226926 --- Description --- Before my commit in revision r464215 (cf. bug #226533)=20 Tools/scripts/bump-revision.sh would wreak havoc on the multimedia/avidemux* ports. This can hardly be blamed on bump-revision.sh, but a safety belt for this important script would be a good idea. My attached patch tries to accomplish that, but using `make -V PORTREVISION` before and after the bumping and raising an error if the latter value is lower or equal to the former. How to reproduce: % cd $PORTSDIR % svn up -r 464036 multimedia/ % Tools/scripts/bump-revision.sh multimedia/avidemux* With my patch this prints: INFO: multimedia/avidemux PORTREVISION=3D 9 found, bumping it by 1. INFO: multimedia/avidemux-cli PORTREVISION not found, adding PORTREVISION= =3D 1 ERROR: multimedia/avidemux-cli PORTREVISION went backwards from 5 to 1! INFO: multimedia/avidemux-plugins PORTREVISION not found, adding PORTREVISION=3D 1=20 ERROR: multimedia/avidemux-plugins PORTREVISION went backwards from 5 to = 1! INFO: multimedia/avidemux-qt4 PORTREVISION not found, adding PORTREVISION= =3D 1 ERROR: multimedia/avidemux-qt4 PORTREVISION went backwards from 5 to 1! The beauty of my approach is that it uses a different approach than simple text search, and the one that the ports framework actually uses when it run= s. Happy to tweak that patch, otherwise also happy to commit this if you approve.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-226926-12827-of0wjbLt7k>