Date: Tue, 22 Apr 2008 00:19:57 -0700 From: Xin LI <delphij@delphij.net> To: Jeremy Messenger <mezz7@cox.net> Cc: gnome@freebsd.org, d@delphij.net Subject: Re: Can someone review this? [Fwd: Re: ports/122975: [PATCH] Fix for mail/thunderbird SIGFPE crash on FreeBSD/amd64] Message-ID: <480D919D.50500@delphij.net> In-Reply-To: <op.t9z1w9ro9aq2h7@mezz.mezzweb.com> References: <480D6CEC.5030007@delphij.net> <1208841455.87116.11.camel@shumai.marcuscom.com> <op.t9z1w9ro9aq2h7@mezz.mezzweb.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jeremy Messenger wrote: | On Tue, 22 Apr 2008 00:17:35 -0500, Joe Marcus Clarke | <marcus@marcuscom.com> wrote: | |> On Mon, 2008-04-21 at 21:43 -0700, Xin LI wrote: | ATT. This fixes a very nasty issue which prevents me from being able to | use enigmime-thunderbird. |>> |>> Approved. | |> Do other gecko ports need same change in Double.cpp? | |> # find /usr/ports -name patch-Double.cpp |> /usr/ports/mail/lightning/files/patch-Double.cpp |> /usr/ports/mail/thunderbird/files/patch-Double.cpp |> /usr/ports/www/firefox/files/patch-Double.cpp |> /usr/ports/www/firefox15/files/patch-Double.cpp |> /usr/ports/www/flock/files/patch-Double.cpp |> /usr/ports/www/mozilla/files/patch-Double.cpp I think so but we really need to check it in a case-by-case basis (I can do this when I have some spare time, but will really appreciate if someone who uses these everyday to provide a hand :). To make a long story short, it seems that the floating number implementation of the javascript engine uses some hackish magic which will raise upperflow exception on, at least, FreeBSD/i386 and amd64. Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkgNkZ0ACgkQi+vbBBjt66Bz2wCbBPnWmFuVBR8huG+QchDtCq58 T6oAoKALA0MePIlN5PSFMLc4hGevxpnM =GATO -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?480D919D.50500>