Date: Fri, 3 Feb 2017 23:12:38 -0500 From: Alexander Kabaev <kabaev@gmail.com> To: "Jason A. Harmening" <jah@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313037 - in head/sys: amd64/include kern mips/include net powerpc/include sparc64/include Message-ID: <20170203231238.0675c289@kan> In-Reply-To: <201702010332.v113WnYf041362@repo.freebsd.org> References: <201702010332.v113WnYf041362@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/qc8uWeVfq6fCjBto+huGfjq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 1 Feb 2017 03:32:49 +0000 (UTC) "Jason A. Harmening" <jah@FreeBSD.org> wrote: > Author: jah > Date: Wed Feb 1 03:32:49 2017 > New Revision: 313037 > URL: https://svnweb.freebsd.org/changeset/base/313037 >=20 > Log: > Implement get_pcpu() for the remaining architectures and use it to > replace pcpu_find(curcpu) in MI code. >=20 > Modified: > head/sys/amd64/include/pcpu.h > head/sys/kern/kern_rmlock.c > head/sys/mips/include/pcpu.h > head/sys/net/netisr.c > head/sys/powerpc/include/cpufunc.h > head/sys/powerpc/include/pcpu.h > head/sys/sparc64/include/pcpu.h >=20 Hi, this change was not reviewed nor testing was thought for all architectures it touches. The change happens to break MIPS quite thoroughly, since MIPS is using different pointers when accessing PCPU area locally and when doing iterations using cpu_to_cpuid array. I therefore officially am requesting this change to be reverted until reasonable solution is found to unbreak architectures that use wired TLBs to access local per-CPU data. --=20 Alexander Kabaev --Sig_/qc8uWeVfq6fCjBto+huGfjq Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEExffZlZm2QeE8UVaRBxMimZJ5Ln4FAliVVLZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM1 RjdEOTk1OTlCNjQxRTEzQzUxNTY5MTA3MTMyMjk5OTI3OTJFN0UACgkQBxMimZJ5 Ln5C5BAAi+BeKHGRfGjrUvBD1Bkx6bRcIoFJMgrZ1bLrRtH+ibGeMeGnwnLwZ6Th lmkWFj1hDJ0UEem6KXtyM+8LQm0BKkJr+5Vc6Fdt9QDIAmagsct6jpQFgmh4Q+/5 Gh0hBWMlHUJW4MsMW6bT8v8qw3jmDxf7UE6lrivrW/ul7zn4x8WCIW9NXB3DG70G Cf/JVHM7lcYj9S+7kxdU4v5Ct+xkOT4AUWiumVUKbO+DPdh973QoMgr1fsVGU7Nv O/ykcvJwdscGwp8eDgIWuwsFEEl1gZzBNQGZyRIBt9qt06AJmpvQ9rq0/bMA2I1L HulsIWq9QU5+ghTBuz8xcwL9Jc7NcykFWJhnBopxR+2Yr6rTjsNPv4WqzyigwakO 6+qYvCWCC+lTyZV9BkczUu9uXFHIgMxxfRKogNxRQ1ukUH/pPbJSY15f82MAmCQi MxvjnTwF8j6QSjsmwM1tfZOTEuGmVBXTTZCI2H5EFow/9FwZhSXNxa0JgqfuyXCq VClSqSS6tEdnCZS+kHVYgmzj1886iDzYJ4v+qSb0/18l677xSdVnpriFLKfLiKMH ObEUzRQlLcELOeRSjFIoS9h/Mi/1ylrlWtela95QDeXxfOiLHNCs5WWuJysWj77H oNUjkrDqoNfmpRReqKstEi3ojbsr9h7PlNwp1SR9cwLa0f8ZlLo= =4S6O -----END PGP SIGNATURE----- --Sig_/qc8uWeVfq6fCjBto+huGfjq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170203231238.0675c289>