Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 08 Jan 2020 21:18:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        gecko@FreeBSD.org
Subject:   maintainer-approval requested: [Bug 242523] security/nss 3.48 doesn't build on PowerPC : [Attachment 210548] v2
Message-ID:  <bug-242523-21738-Efej4iLpEx@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-242523-21738@https.bugs.freebsd.org/bugzilla/>
References:  <bug-242523-21738@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
Piotr Kubaj <pkubaj@FreeBSD.org> has asked freebsd-gecko mailing list
<gecko@FreeBSD.org> for maintainer-approval:
Bug 242523: security/nss 3.48 doesn't build on PowerPC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242523

Attachment 210548: v2
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D210548&action=3Dedit



--- Comment #17 from Piotr Kubaj <pkubaj@FreeBSD.org> ---
Created attachment 210548
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D210548&action=
=3Dedit
v2

- Fix build without AltiVec, Crypto and VSX by moving altivec-types.h inclu=
de
to USE_PPC_CRYPTO's ifdef -this header is not necessary without USE_PPC_CRY=
PTO
enabled,
- Enable USE_PPC_CRYPTO on BE as well if VSX and Crypto are supported,
- Add non-default VSX option for adding -mvsx -mcrypto to set USE_PPC_CRYPT=
O,
- since we don't need new GCC now, don't set USES=3Dcompiler:c11 by default.

This fixes powerpc and powerpc64 build without AltiVec, Crypto and VSX and
makes it possible to use USE_PPC_CRYPTO which should accelerate things.

make test output without this patch:
Passed: 	    14415
Failed: 	    58
Failed with core:   0
ASan failures:	    0
Unknown status:     52
TinderboxPrint:Unknown: 52

And with:
Passed: 	    14471
Failed: 	    2
Failed with core:   0
ASan failures:	    0
Unknown status:     52
TinderboxPrint:Unknown: 52



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-242523-21738-Efej4iLpEx>