Date: Sun, 25 Mar 2001 02:13:45 +0200 (EET) From: Maxim Sobolev <sobomax@FreeBSD.ORG> To: kris@obsecurity.org (Kris Kennaway) Cc: kapr@acm.org (Alex Kapranoff), ports@FreeBSD.ORG Subject: Re: Conditionalizing MACHINE_CPU checks Message-ID: <200103250013.f2P0Djr06954@vic.sabbo.net> In-Reply-To: <20010324154609.A42192@xor.obsecurity.org> from "Kris Kennaway" at Mar 24, 2001 03:46:09 PM
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mon, Mar 19, 2001 at 09:13:53AM +0300, Alex Kapranoff wrote:
> > Good day to all.
> >=20
> > Do I really need to wrap MACHINE_CPU tests (like ${MACHINE_CPU:Mmmx})
> > inside ${OSVERSION} >=3D 500018 tests?
>
> It's also in RELENG_4 now, so you should use check for
>
> ${OSVERSION} >=3D 500018 || ( ${OSVERSION} < 500000 && ${OSVERSION} >=3D 43=
> 0000 )
>
> > E.g. is it ok to do tests in this way:
> >=20
> > .if defined(WITH_MMX) || ${MACHINE_CPU:Mmmx}
> > SRCS+=3D mmx.c
> > .elif ${ARCH} =3D=3D "i386"
> > @${ECHO_MSG} "You can define WITH_MMX to use MMX instructions"
> > .endif
>
> I'd prefer to keep it under an .if OSVERSION test, so it becomes
> easier to just chop out the .else section when we stop supporting
> systems older than ${OSVERSION} =3D=3D 430000
I think that the best way is to add HAVE_CPU_MK into bsd.port.mk,
so we will hot have to repeat the same OSVERSION checks in every
port.
-Maxim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103250013.f2P0Djr06954>