Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 26 Apr 2017 23:01:49 +0000 (UTC)
From:      Rick Macklem <rmacklem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r317475 - stable/10/sys/fs/nfsclient
Message-ID:  <201704262301.v3QN1n57020278@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: rmacklem
Date: Wed Apr 26 23:01:49 2017
New Revision: 317475
URL: https://svnweb.freebsd.org/changeset/base/317475

Log:
  MFC: r316719
  Don't throw away Open state when a NFSv4.1 client recovery fails.
  
  If the ExchangeID/CreateSession operations done by an NFSv4.1 client
  after the server crashes/reboots fails, it is possible that some process/thread
  is waiting for an open_owner lock. If the client state is free'd, this
  can cause a crash.
  This would not normally happen, but has been observed on a mount of the
  AmazonEFS service.

Modified:
  stable/10/sys/fs/nfsclient/nfs_clstate.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/fs/nfsclient/nfs_clstate.c
==============================================================================
--- stable/10/sys/fs/nfsclient/nfs_clstate.c	Wed Apr 26 22:53:29 2017	(r317474)
+++ stable/10/sys/fs/nfsclient/nfs_clstate.c	Wed Apr 26 23:01:49 2017	(r317475)
@@ -1934,10 +1934,9 @@ nfscl_recover(struct nfsclclient *clp, s
 	     error == NFSERR_BADSESSION ||
 	     error == NFSERR_STALEDONTRECOVER) && --trycnt > 0);
 	if (error) {
-		nfscl_cleanclient(clp);
 		NFSLOCKCLSTATE();
-		clp->nfsc_flags &= ~(NFSCLFLAGS_HASCLIENTID |
-		    NFSCLFLAGS_RECOVER | NFSCLFLAGS_RECVRINPROG);
+		clp->nfsc_flags &= ~(NFSCLFLAGS_RECOVER |
+		    NFSCLFLAGS_RECVRINPROG);
 		wakeup(&clp->nfsc_flags);
 		nfsv4_unlock(&clp->nfsc_lock, 0);
 		NFSUNLOCKCLSTATE();
@@ -2254,13 +2253,8 @@ nfscl_hasexpired(struct nfsclclient *clp
 	     error == NFSERR_BADSESSION ||
 	     error == NFSERR_STALEDONTRECOVER) && --trycnt > 0);
 	if (error) {
-		/*
-		 * Clear out any state.
-		 */
-		nfscl_cleanclient(clp);
 		NFSLOCKCLSTATE();
-		clp->nfsc_flags &= ~(NFSCLFLAGS_HASCLIENTID |
-		    NFSCLFLAGS_RECOVER);
+		clp->nfsc_flags &= ~NFSCLFLAGS_RECOVER;
 	} else {
 		/*
 		 * Expire the state for the client.

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704262301.v3QN1n57020278>