Date: Tue, 1 Jul 2014 15:02:15 +0900 From: "Lundberg, Johannes" <johannes@brilliantservice.co.jp> To: Hans Petter Selasky <hps@selasky.org> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Fredrik Lindberg <fli@shapeshifter.se> Subject: Re: ucom_free Fatal trap on shutdown / module unload Message-ID: <CAASDrVnj%2B4%2BEqMMDpGvzHzEXXDeDpY1p8z4PZ49LA6p22DBZqw@mail.gmail.com> In-Reply-To: <53B24820.2020800@selasky.org> References: <CAASDrVkFfhyU8Jb4EB%2B4V32skfFijX9TKLSysjGK=0ye=G9GgA@mail.gmail.com> <53A90116.7040306@selasky.org> <CAASDrVnfxR40OsJLRLQUfyzhBHuHynYAqmaq=9EBUxZHMUCYnw@mail.gmail.com> <CAASDrVmYCdZ8UOsp7yESpi2KBDvQgG2HvSGrWGUyiETcpz7Y_g@mail.gmail.com> <53A907E9.5020007@selasky.org> <CAASDrVkPK0M2caZ0wmfwJrTGF5h99-4s71KfuRcNFEOcWtAqCA@mail.gmail.com> <53A9C37A.7030803@selasky.org> <CAASDrV=CDX4mSdZRNcSgNgWWscntt8xd4a2sfGnKuBmPKkd-%2BA@mail.gmail.com> <53AA5A0E.1050704@selasky.org> <CAASDrV=a0kc0QAxa3MuVq1qvfW_yun%2BeUr0E360oCsPF7tWTvg@mail.gmail.com> <53AC8C21.6080504@selasky.org> <CAASDrV=AupNhXrXQfoecidm4sWokxrG4qfa3tMJ4raYQUSaJEA@mail.gmail.com> <53AD01C6.1080005@selasky.org> <CAASDrVnezuH4iyAU5CbBZdWziVxgmoa7EuBX1ESNB7kXN5w4vA@mail.gmail.com> <53AED789.9070504@selasky.org> <CAASDrVnGMb81FxfJBQrdYwf_W=mpd=xvfgWTneOuuL=9cexDOA@mail.gmail.com> <53B0E3FD.30800@selasky.org> <CAASDrV=Vp4TpuKfpz1T8QDxfE7n=r%2BdeJVuN2O7tB1YT8uFyzg@mail.gmail.com> <53B24820.2020800@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
SGkgSGFucw0KDQpUaGFua3MgZm9yIHRoZSB1aHNvIHBhdGNoLiBUaGF0IGRpZCB0aGUgdHJpY2su IE5vdyByZWJvb3QgYW5kIGtsZHVubG9hZA0Kd29ya3MgZmluZS4NCg0KLS0NCkpvaGFubmVzIEx1 bmRiZXJnDQpCUklMTElBTlRTRVJWSUNFIENPLiwgTFRELg0KDQoNCk9uIFR1ZSwgSnVsIDEsIDIw MTQgYXQgMjozMyBQTSwgSGFucyBQZXR0ZXIgU2VsYXNreSA8aHBzQHNlbGFza3kub3JnPiB3cm90 ZToNCg0KPiBIaSwNCj4NCj4gVHJ5IHRoZSBhdHRhY2hlZCBwYXRjaC4gRG9lcyBpdCBtYWtlIGFu eSBkaWZmZXJlbmNlPw0KPg0KPiAtLUhQUw0KPg0KCi0tIAo9LT0tPS09LT0tPS09LT0tPS09LT0t PS09LT0tPS09LT0tPS09LT0tPS09LT0tPS09LT0tPS0K56eY5a+G5L+d5oyB44Gr44Gk44GE44Gm 77ya44GT44Gu6Zu75a2Q44Oh44O844Or44Gv44CB5ZCN5a6b5Lq644Gr6YCB5L+h44GX44Gf44KC 44Gu44Gn44GC44KK44CB56eY5Yy/54m55qip44Gu5a++6LGh44Go44Gq44KL5oOF5aCx44KS5ZCr 44KT44Gn44GE44G+44GZ44CCCuOCguOBl+OAgeWQjeWum+S6uuS7peWkluOBruaWueOBjOWPl+S/ oeOBleOCjOOBn+WgtOWQiOOAgeOBk+OBruODoeODvOODq+OBruegtOajhOOAgeOBiuOCiOOBs+OB k+OBruODoeODvOODq+OBq+mWouOBmeOCi+S4gOWIh+OBrumWi+ekuuOAgQropIflhpnjgIHphY3l uIPjgIHjgZ3jga7ku5bjga7liKnnlKjjgIHjgb7jgZ/jga/oqJjovInlhoXlrrnjgavln7rjgaXj gY/jgYTjgYvjgarjgovooYzli5XjgoLjgZXjgozjgarjgYTjgojjgYbjgYrpoZjjgYTnlLPjgZfk uIrjgZLjgb7jgZnjgIIKLS0tCkNPTkZJREVOVElBTElUWSBOT1RFOiBUaGUgaW5mb3JtYXRpb24g aW4gdGhpcyBlbWFpbCBpcyBjb25maWRlbnRpYWwKYW5kIGludGVuZGVkIHNvbGVseSBmb3IgdGhl IGFkZHJlc3NlZS4KRGlzY2xvc3VyZSwgY29weWluZywgZGlzdHJpYnV0aW9uIG9yIGFueSBvdGhl ciBhY3Rpb24gb2YgdXNlIG9mIHRoaXMKZW1haWwgYnkgcGVyc29uIG90aGVyIHRoYW4gaW50ZW5k ZWQgcmVjaXBpZW50LCBpcyBwcm9oaWJpdGVkLgpJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5kZWQg cmVjaXBpZW50IGFuZCBoYXZlIHJlY2VpdmVkIHRoaXMgZW1haWwgaW4KZXJyb3IsIHBsZWFzZSBk ZXN0cm95IHRoZSBvcmlnaW5hbCBtZXNzYWdlLgo= From owner-freebsd-current@FreeBSD.ORG Tue Jul 1 05:33:07 2014 Return-Path: <owner-freebsd-current@FreeBSD.ORG> Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E2DA1683 for <freebsd-current@freebsd.org>; Tue, 1 Jul 2014 05:33:07 +0000 (UTC) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 93E022556 for <freebsd-current@freebsd.org>; Tue, 1 Jul 2014 05:33:06 +0000 (UTC) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id A6B0F1FE02D; Tue, 1 Jul 2014 07:33:03 +0200 (CEST) Message-ID: <53B24820.2020800@selasky.org> Date: Tue, 01 Jul 2014 07:33:20 +0200 From: Hans Petter Selasky <hps@selasky.org> User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: "Lundberg, Johannes" <johannes@brilliantservice.co.jp> Subject: Re: ucom_free Fatal trap on shutdown / module unload References: <CAASDrVkFfhyU8Jb4EB+4V32skfFijX9TKLSysjGK=0ye=G9GgA@mail.gmail.com> <53A90116.7040306@selasky.org> <CAASDrVnfxR40OsJLRLQUfyzhBHuHynYAqmaq=9EBUxZHMUCYnw@mail.gmail.com> <CAASDrVmYCdZ8UOsp7yESpi2KBDvQgG2HvSGrWGUyiETcpz7Y_g@mail.gmail.com> <53A907E9.5020007@selasky.org> <CAASDrVkPK0M2caZ0wmfwJrTGF5h99-4s71KfuRcNFEOcWtAqCA@mail.gmail.com> <53A9C37A.7030803@selasky.org> <CAASDrV=CDX4mSdZRNcSgNgWWscntt8xd4a2sfGnKuBmPKkd-+A@mail.gmail.com> <53AA5A0E.1050704@selasky.org> <CAASDrV=a0kc0QAxa3MuVq1qvfW_yun+eUr0E360oCsPF7tWTvg@mail.gmail.com> <53AC8C21.6080504@selasky.org> <CAASDrV=AupNhXrXQfoecidm4sWokxrG4qfa3tMJ4raYQUSaJEA@mail.gmail.com> <53AD01C6.1080005@selasky.org> <CAASDrVnezuH4iyAU5CbBZdWziVxgmoa7EuBX1ESNB7kXN5w4vA@mail.gmail.com> <53AED789.9070504@selasky.org> <CAASDrVnGMb81FxfJBQrdYwf_W=mpd=xvfgWTneOuuL=9cexDOA@mail.gmail.com> <53B0E3FD.30800@selasky.org> <CAASDrV=Vp4TpuKfpz1T8QDxfE7n=r+deJVuN2O7tB1YT8uFyzg@mail.gmail.com> In-Reply-To: <CAASDrV=Vp4TpuKfpz1T8QDxfE7n=r+deJVuN2O7tB1YT8uFyzg@mail.gmail.com> Content-Type: multipart/mixed; boundary="------------030502030109090002050804" Cc: FreeBSD Current <freebsd-current@freebsd.org>, Fredrik Lindberg <fli@shapeshifter.se> X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current <freebsd-current.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>; List-Post: <mailto:freebsd-current@freebsd.org> List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=subscribe> X-List-Received-Date: Tue, 01 Jul 2014 05:33:08 -0000 This is a multi-part message in MIME format. --------------030502030109090002050804 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Try the attached patch. Does it make any difference? --HPS --------------030502030109090002050804 Content-Type: text/x-patch; name="uhso.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="uhso.diff" === uhso.c ================================================================== --- uhso.c (revision 268059) +++ uhso.c (local) @@ -559,8 +559,6 @@ mtx_init(&sc->sc_mtx, "uhso", NULL, MTX_DEF); ucom_ref(&sc->sc_super_ucom); - sc->sc_ucom = NULL; - sc->sc_ttys = 0; sc->sc_radio = 1; id = usbd_get_interface_descriptor(uaa->iface); @@ -680,9 +678,6 @@ UHSO_CTRL_MAX); } } - - free(sc->sc_tty, M_USBDEV); - free(sc->sc_ucom, M_USBDEV); } if (sc->sc_ifp != NULL) { @@ -710,6 +705,8 @@ uhso_free_softc(struct uhso_softc *sc) { if (ucom_unref(&sc->sc_super_ucom)) { + free(sc->sc_tty, M_USBDEV); + free(sc->sc_ucom, M_USBDEV); mtx_destroy(&sc->sc_mtx); device_free_softc(sc); } --------------030502030109090002050804--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAASDrVnj%2B4%2BEqMMDpGvzHzEXXDeDpY1p8z4PZ49LA6p22DBZqw>