Date: Mon, 14 Dec 1998 00:48:27 +0100 (CET) From: Nick Hibma <nick.hibma@jrc.it> To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Cc: "Justin T. Gibbs" <gibbs@plutotech.com>, Julian Elischer <julian@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/usb ohci.c Message-ID: <Pine.BSF.3.96.981214004558.940F-100000@heidi.plazza.it> In-Reply-To: <199812121945.OAA05272@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> >> This fixes the symptom and not the cause. > >> The right answer is to let the PCI system know that the attach failed, > >> or to fail earlier (in the PCI probe). > >> The attach() is a void fn() so it can't return failure.. > > > pci_unmap_int should also be implemented. > > It's called BUS_TEARDOWN_INTR(). I don't think that that takes care of the PCI interrupt itself. It's only a framework from what I can see. ./compile/USB/bus_if.h:bus_teardown_intr_t BUS_TEARDOWN_INTR; ./compile/USB/bus_if.c:int BUS_TEARDOWN_INTR(device_t dev, device_t child, struct resource *irq, ./kern/subr_bus.c: return (BUS_TEARDOWN_INTR(dev->parent, dev, irq, cookie)); Cheers, Nick -- e-Mail: n_hibma@etla.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.981214004558.940F-100000>