Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Apr 2006 02:41:58 GMT
From:      John Birrell <jb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 95983 for review
Message-ID:  <200604240241.k3O2fw8m072836@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=95983

Change 95983 by jb@jb_freebsd2 on 2006/04/24 02:41:58

	Document the names of the provider operations structure init
	so that the code is readable. I'm not sure I like function casts
	like that.
	
	Remove the error thread pointer because we aren't using it (yet).

Affected files ...

.. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace.c#14 edit

Differences ...

==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace.c#14 (text+ko) ====

@@ -242,15 +242,25 @@
 {}
 
 static dtrace_pops_t	dtrace_provider_ops = {
+	/* dtps_provide */
 	(void (*)(void *, const dtrace_probedesc_t *))dtrace_nullop,
+	/* dtps_provide_module */
 	(void (*)(void *, struct modctl *))dtrace_nullop,
+	/* dtps_enable */
 	(void (*)(void *, dtrace_id_t, void *))dtrace_nullop,
+	/* dtps_disable */
 	(void (*)(void *, dtrace_id_t, void *))dtrace_nullop,
+	/* dtps_suspend */
 	(void (*)(void *, dtrace_id_t, void *))dtrace_nullop,
+	/* dtps_resume */
 	(void (*)(void *, dtrace_id_t, void *))dtrace_nullop,
+	/* dtps_getargdesc */
 	NULL,
+	/* dtps_getargval */
 	NULL,
+	/* dtps_usermode */
 	NULL,
+	/* dtps_destroy */
 	(void (*)(void *, dtrace_id_t, void *))dtrace_nullop
 };
 
@@ -284,7 +294,6 @@
 #ifdef DEBUG
 static dtrace_errhash_t	dtrace_errhash[DTRACE_ERRHASHSZ];
 static const char *dtrace_errlast;
-static kthread_t *dtrace_errthread;
 static kmutex_t dtrace_errlock;
 #endif
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604240241.k3O2fw8m072836>