Date: Thu, 31 Jan 2008 05:53:58 -0500 From: John Baldwin <jhb@freebsd.org> To: freebsd-hackers@freebsd.org Cc: Pietro Cerutti <gahr@gahr.ch> Subject: Re: more on devstat (missing include) Message-ID: <200801310553.59141.jhb@freebsd.org> In-Reply-To: <47A103A1.4030108@gahr.ch> References: <47A103A1.4030108@gahr.ch>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 30 January 2008 06:09:21 pm Pietro Cerutti wrote:
> Hi hackers,
>
> I think that i) sys/devicestat.h should include sys/resource.h or ii)
> the man page of devstat(9) should mention that the user himself is
> supposed to include sys/resource.h.
>
> Without:
>
> > cat devstat.c
> #include <devstat.h>
>
> int main(void)
> {
> devstat_getnumdevs(NULL);
> return (0);
> }
> > gcc -ldevstat -o devstat devstat.c
> In file included from devstat.c:1:
> /usr/include/devstat.h:131: error: 'CPUSTATES' undeclared here (not in a
> function)
> Exit 1
>
>
> I can provide a patch if someone could tell me which one of the proposed
> solutions above is the preferred one.
I think this might be best:
Index: devstat.h
===================================================================
RCS file: /usr/cvs/src/lib/libdevstat/devstat.h,v
retrieving revision 1.11
diff -u -r1.11 devstat.h
--- devstat.h 22 Jul 2005 17:19:00 -0000 1.11
+++ devstat.h 31 Jan 2008 10:52:37 -0000
@@ -32,6 +32,7 @@
#define _DEVSTAT_H
#include <sys/cdefs.h>
#include <sys/devicestat.h>
+#include <sys/resource.h>
#include <kvm.h>
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200801310553.59141.jhb>