Date: Fri, 08 Apr 2016 10:48:22 +0000 From: Howard Su <howard0su@gmail.com> To: Alexander Motin <mavbsd@gmail.com>, Konstantin Belousov <kostikbel@gmail.com>, Sepherosa Ziehau <sephe@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r297699 - head/sys/dev/hyperv/vmbus Message-ID: <CAAvnz_q-TMyyJjKQcoPurBDvjpWZ66U6y4pFo9M2iPFc_McvNQ@mail.gmail.com> In-Reply-To: <57077E95.1030505@gmail.com> References: <201604080920.u389KliR048702@repo.freebsd.org> <20160408094248.GM1741@kib.kiev.ua> <57077E95.1030505@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 8, 2016 at 5:49 PM Alexander Motin <mavbsd@gmail.com> wrote: > On 08.04.16 12:42, Konstantin Belousov wrote: > > On Fri, Apr 08, 2016 at 09:20:47AM +0000, Sepherosa Ziehau wrote: > >> Author: sephe > >> Date: Fri Apr 8 09:20:46 2016 > >> New Revision: 297699 > >> URL: https://svnweb.freebsd.org/changeset/base/297699 > >> > >> Log: > >> hyperv: Revert r297481 > >> > >> Use vm_guest == VM_GUEST_HV is not enough to determine whether FreeBSD > >> is running on Hyper-V or not. What a mess. > > > > Can you explain why ? > > > > VM_GUEST_HV is only set in inentify_hypervisor() when the vendor string > > explicitely contained 'Microsoft Hv'. How can this be mis-interpreted > > to be a Xen id ? > > Xen has some odd "Hyper-V compatibility mode", that is identified as > Hyper-V, but not very compatible in practice. > Per hyper-V document, it needs more checks about if one feature is available on certain hypervisor. As far as I know, KVM, QEMU (after 1.1), VirtualBox all have the simliar Windows hypervisor emulation mode to make Windows Runs faster. So we need handle this more strictly following the spec. There is already a patch under testing now, which may reach the tree soon. > > -- > Alexander Motin > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAvnz_q-TMyyJjKQcoPurBDvjpWZ66U6y4pFo9M2iPFc_McvNQ>